Add ARM64 Integration Test - #4897
Merged
Merged
Conversation
Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
aliariff
force-pushed
the
arm-integration-test
branch
from
August 20, 2020 19:03
bfcf79d to
06934ae
Compare
Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
cpretzer
reviewed
Aug 24, 2020
| # Run the upgrade-stable test by upgrading the most-recent stable release to the | ||
| # HEAD of this branch. | ||
| run_upgrade-stable_test() { | ||
| if [ -n "$ARM_TEST" ]; then |
Contributor
There was a problem hiding this comment.
What do you think of naming this something more descriptive like RUN_ARM_TEST
Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
alpeb
reviewed
Aug 27, 2020
Comment on lines
+208
to
+218
| id: install_cli | ||
| run: | | ||
| TAG="$(CI_FORCE_CLEAN=1 bin/root-tag)" | ||
| CMD="$PWD/target/release/linkerd2-cli-$TAG-linux-amd64" | ||
| bin/docker-pull-binaries $TAG | ||
| $CMD version --client | ||
| # validate CLI version matches the repo | ||
| [[ "$TAG" == "$($CMD version --short --client)" ]] | ||
| echo "Installed Linkerd CLI version: $TAG" | ||
| echo "::set-env name=CMD::$CMD" | ||
| echo "::set-output name=tag::$TAG" |
Member
There was a problem hiding this comment.
id: install_cli along with echo "::set-output name=tag::$TAG" is used so that another step can refer to the tag using steps.install_cli.output.tag. It's not used here, so you can remove that id and this statement.
Signed-off-by: Ali Ariff <ali.ariff12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpretzer @alpeb
Changes
arm64_integration_testsjob in the release workflowhelm-upgradeandupgrade-stabletest because the Linkerd stable version does not support ARM yetNote
ARM64_KUBECONFIGwith the kubeconfig credential from the ARM64 machine.Signed-off-by: Ali Ariff ali.ariff12@gmail.com