Repository navigation
Conversation
Introduce BUNDLED_SCHEMAS and a bundled_schema_path pytest fixture to expose schemas bundled with linkml-model (atm this is "arrays" and "extended_datatypes". Add tests that ensure each bundled schema can be loaded via SchemaView and can generate compilable Python using PythonGenerator (written to a temp file and compiled with py_compile). Also add necessary imports in the test module.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3130 +/- ##
==========================================
+ Coverage 79.59% 83.21% +3.62%
==========================================
Files 155 155
Lines 17582 17582
Branches 3595 3595
==========================================
+ Hits 13994 14631 +637
+ Misses 2833 2149 -684
- Partials 755 802 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
matentzn
marked this pull request as draft
February 3, 2026 13:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3129
Depends on #3128
The metamodel compat test suite currently only tests
meta.yaml(the core metamodel). But linkml-model also ships schemas likearrays.yamlandextended_types.yamlthat users are expected to use in their own schemas. If these don't work with the toolkit, that might be a real problem.This PR adds parametrized tests that load each bundled schema with
SchemaViewand generate Python withPythonGenerator. Currently botharraysandextended_typesfail — see #3129 for details.Changes
conftest.py: Addedbundled_schema_pathfixture parametrized over["arrays", "extended_types"]test_metamodel_projectgen.py: Addedtest_bundled_schema_loadsandtest_bundled_schema_python_generatesKnown failures
These tests will fail on main until the underlying issues are fixed:
arrays:slot_usageon slots not supported by runtime loaderextended_types:union_ofon types not handled bySchemaLoader