Skip to content

[TECHOPS-1244] Drop the dry-run ECR claim from the workflows README - #8009

Open
sayaliM0412 wants to merge 1 commit into
mainfrom
techops-1244-drop-dry-run-ecr-docs
Open

[TECHOPS-1244] Drop the dry-run ECR claim from the workflows README#8009
sayaliM0412 wants to merge 1 commit into
mainfrom
techops-1244-drop-dry-run-ecr-docs

Conversation

@sayaliM0412

@sayaliM0412 sayaliM0412 commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔎 What

Removes the sentence (and its screenshot) claiming a dryRun release ends with a docker image in 812559712860.dkr.ecr.us-east-1.amazonaws.com/liquibase-dry-run.

🧨 Why

Neither half of that sentence is true any more:

  • release-published-orchestrator.yml skips docker-release.yml entirely on a dryRun (inputs.dry_run != true), because docker-release.yml resolves the SHA256 from package.liquibase.com, which only hosts GA tarballs.
  • A docker-release.yml run dispatched by hand with dryRun: true used to push to that private ECR repo through build-logic's reusable-docker-build.yml. feat(docker): stop pushing dry-run images to private ECR (TECHOPS-1244) build-logic#707 changes a dry run to build every platform and push to no registry, because nothing in any Liquibase repo ever pulled from liquibase-dry-run, while Inspector kept rescanning the 1,341 images it had accumulated since 2024-08-27.

✅ Verification

  • grep across liquibase, liquibase-pro, docker, build-logic and liquibase-infrastructure: no workflow, script or QA job pulls from liquibase-dry-run.
  • The remaining dryRun outputs listed in this section (Maven, deb, rpm, sdkman) are unchanged.

📦 Scope

Docs only: one sentence in .github/workflows/README.md and the now-unreferenced doc/img/ecr.png. No workflow behaviour changes in this repo.

🤖 Generated with Claude Code

@sayaliM0412 @claude
[TECHOPS-1244] Drop the dry-run ECR claim from the workflows README
d9c680f 
The README said a dryRun release ends with a docker image in
812559712860.dkr.ecr.us-east-1.amazonaws.com/liquibase-dry-run. Neither
half of that is true any more: release-published-orchestrator.yml skips
docker-release.yml on a dryRun, and build-logic's reusable-docker-build.yml
no longer pushes anywhere on a dry run.

The ecr.png screenshot went with the sentence that referenced it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sayaliM0412
sayaliM0412 requested a review from a team as a code owner September 18, 2026 17:39
@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c5ee3ec1-5643-4a21-93df-7c648380eefc

📥 Commits

Reviewing files that changed from the base of the PR and between 944e1c2 and d9c680f.

⛔ Files ignored due to path filters (1)
  • .github/workflows/doc/img/ecr.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • .github/workflows/README.md

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The workflow README updates the dryRun release documentation. It states that Docker images are not published, describes the relevant workflow behavior, and removes the obsolete ECR image reference.

Changes

Dry-run release documentation

Layer / File(s) Summary
Document dry-run Docker behavior
.github/workflows/README.md		 The README explains that dryRun releases skip docker-release.yml. It also states that dispatched Docker releases build all platforms without pushing to a registry. The obsolete ECR image reference was removed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: jandroav

Merge Risk: ⚪ Minimal · up to d9c68

This documentation-only change does not alter workflow behavior and presents no actionable merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: removing the outdated dry-run ECR claim from the workflows README.
Description check ✅ Passed The description explains what changed, why the claim was incorrect, how the change was verified, and the scope. It does not use every template heading, but it provides the required core information fo…
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sayaliM0412 sayaliM0412 mentioned this pull request Sep 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandroav jandroav jandroav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sayaliM0412 @jandroav