fix(lit-html): detect incomplete document mocks for TreeWalker#5365
Open
Hashim1999164 wants to merge 1 commit into
Open
fix(lit-html): detect incomplete document mocks for TreeWalker#5365Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Stencil and similar Jest document mocks define document but omit createTreeWalker. Check for that method so the Node stub still applies. Fixes lit#4855
🦋 Changeset detectedLatest commit: 494b223 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4855 by treating a document without
createTreeWalkerthe same as a missing document in Node mode.Some test environments (for example Stencil Jest) provide a mock
documentthat does not implementcreateTreeWalker. Lit only installed its TreeWalker stub whendocumentwasundefined, so those mocks still threwcreateTreeWalker is not a function.Test plan
typeof global.document?.createTreeWalker !== 'function'