Fix some errors pointed out by the internal linter. by bicknellr · Pull Request #2096 · lit/lit

bicknellr · 2021-08-26T22:43:09Z

The linter pointed out most of these while I was trying an import and there's a few others I found while looking through the import result.

changeset-bot · 2021-08-26T22:43:11Z

🦋 Changeset detected

Latest commit: 3f154bf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2021-08-26T22:43:27Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -4% - +5% (-1.62ms - +1.70ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -3% - +2% (-3.40ms - +1.69ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +6% (-1.44ms - +2.61ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -15% - +5% (-2.20ms - +0.73ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -4% - +1% (-2.95ms - +0.52ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -4% - +2% (-2.62ms - +1.66ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -1% - +3% (-7.98ms - +25.98ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -4% - +4% (-4.97ms - +4.93ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -8% - +9% (-35.88ms - +38.10ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -3% - +4% (-4.25ms - +5.25ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -4% - +3% (-32.51ms - +27.28ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -4% - +1% (-31.45ms - +5.74ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +4% (-23.84ms - +36.98ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 92.0.4515.159
Sample size: 50
Built by: Benchmarks #1907
Commit: ab1f53a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	94.44ms - 97.94ms	-	unsure 🔍 -3% - +2% -3.40ms - +1.69ms	faster ✔ 23% - 28% 28.86ms - 36.19ms
tip-of-tree tip-of-tree	95.19ms - 98.89ms	unsure 🔍 -2% - +4% -1.69ms - +3.40ms	-	faster ✔ 22% - 27% 27.96ms - 35.39ms
previous-release previous-release	125.50ms - 131.94ms	slower ❌ 30% - 38% 28.86ms - 36.19ms	slower ❌ 28% - 37% 27.96ms - 35.39ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	771.01ms - 793.10ms	-	unsure 🔍 -1% - +3% -7.98ms - +25.98ms	faster ✔ 7% - 11% 55.78ms - 91.89ms
tip-of-tree tip-of-tree	760.16ms - 785.95ms	unsure 🔍 -3% - +1% -25.98ms - +7.98ms	-	faster ✔ 8% - 12% 63.59ms - 102.07ms
previous-release previous-release	841.61ms - 870.17ms	slower ❌ 7% - 12% 55.78ms - 91.89ms	slower ❌ 8% - 13% 63.59ms - 102.07ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	770.18ms - 795.06ms	-	unsure 🔍 -4% - +1% -31.45ms - +5.74ms	faster ✔ 7% - 11% 59.13ms - 98.02ms
tip-of-tree tip-of-tree	781.65ms - 809.29ms	unsure 🔍 -1% - +4% -5.74ms - +31.45ms	-	faster ✔ 5% - 10% 45.36ms - 86.08ms
previous-release previous-release	846.24ms - 876.14ms	slower ❌ 7% - 13% 59.13ms - 98.02ms	slower ❌ 6% - 11% 45.36ms - 86.08ms	-

lit-html-kitchen-sink

Browser: chrome-headless 92.0.4515.159
Sample size: 30
Built by: Benchmarks #1907
Commit: ab1f53a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	45.16ms - 48.26ms	-	unsure 🔍 -3% - +6% -1.44ms - +2.61ms	faster ✔ 10% - 19% 5.46ms - 10.71ms
tip-of-tree tip-of-tree	44.81ms - 47.43ms	unsure 🔍 -6% - +3% -2.61ms - +1.44ms	-	faster ✔ 12% - 20% 6.18ms - 11.16ms
previous-release previous-release	52.68ms - 56.92ms	slower ❌ 11% - 23% 5.46ms - 10.71ms	slower ❌ 13% - 25% 6.18ms - 11.16ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	111.08ms - 118.11ms	-	unsure 🔍 -4% - +4% -4.97ms - +4.93ms	unsure 🔍 -8% - +1% -9.50ms - +1.50ms
tip-of-tree tip-of-tree	111.13ms - 118.11ms	unsure 🔍 -4% - +4% -4.93ms - +4.97ms	-	unsure 🔍 -8% - +1% -9.46ms - +1.50ms
previous-release previous-release	114.37ms - 122.82ms	unsure 🔍 -1% - +8% -1.50ms - +9.50ms	unsure 🔍 -1% - +8% -1.50ms - +9.46ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	36.12ms - 38.28ms	-	unsure 🔍 -4% - +5% -1.62ms - +1.70ms	unsure 🔍 -6% - +4% -2.34ms - +1.41ms
tip-of-tree tip-of-tree	35.91ms - 38.43ms	unsure 🔍 -5% - +4% -1.70ms - +1.62ms	-	unsure 🔍 -7% - +4% -2.49ms - +1.49ms
previous-release previous-release	36.13ms - 39.20ms	unsure 🔍 -4% - +6% -1.41ms - +2.34ms	unsure 🔍 -4% - +7% -1.49ms - +2.49ms	-

lit-html-repeat

Browser: chrome-headless 92.0.4515.159
Sample size: 30
Built by: Benchmarks #1907
Commit: ab1f53a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	12.98ms - 14.53ms	-	unsure 🔍 -15% - +5% -2.20ms - +0.73ms	faster ✔ 5% - 23% 0.60ms - 3.90ms
tip-of-tree tip-of-tree	13.25ms - 15.74ms	unsure 🔍 -5% - +16% -0.73ms - +2.20ms	-	unsure 🔍 -21% - +2% -3.42ms - +0.40ms
previous-release previous-release	14.55ms - 17.46ms	slower ❌ 4% - 29% 0.60ms - 3.90ms	unsure 🔍 -3% - +24% -0.40ms - +3.42ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	410.69ms - 460.92ms	-	unsure 🔍 -8% - +9% -35.88ms - +38.10ms	faster ✔ 25% - 37% 145.02ms - 246.59ms
tip-of-tree tip-of-tree	407.55ms - 461.85ms	unsure 🔍 -9% - +8% -38.10ms - +35.88ms	-	faster ✔ 25% - 38% 145.10ms - 248.73ms
previous-release previous-release	587.47ms - 675.75ms	slower ❌ 32% - 58% 145.02ms - 246.59ms	slower ❌ 32% - 59% 145.10ms - 248.73ms	-

lit-html-template-heavy

Browser: chrome-headless 92.0.4515.159
Sample size: 50
Built by: Benchmarks #1907
Commit: ab1f53a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	67.82ms - 70.38ms	-	unsure 🔍 -4% - +1% -2.95ms - +0.52ms	faster ✔ 14% - 18% 11.21ms - 15.35ms
tip-of-tree tip-of-tree	69.14ms - 71.48ms	unsure 🔍 -1% - +4% -0.52ms - +2.95ms	-	faster ✔ 12% - 17% 10.07ms - 14.07ms
previous-release previous-release	80.76ms - 84.00ms	slower ❌ 16% - 22% 11.21ms - 15.35ms	slower ❌ 14% - 20% 10.07ms - 14.07ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	140.60ms - 146.61ms	-	unsure 🔍 -3% - +4% -4.25ms - +5.25ms	faster ✔ 9% - 14% 14.09ms - 23.41ms
tip-of-tree tip-of-tree	139.43ms - 146.78ms	unsure 🔍 -4% - +3% -5.25ms - +4.25ms	-	faster ✔ 9% - 15% 14.13ms - 24.37ms
previous-release previous-release	158.79ms - 165.92ms	slower ❌ 10% - 16% 14.09ms - 23.41ms	slower ❌ 10% - 17% 14.13ms - 24.37ms	-

reactive-element-list

Browser: chrome-headless 92.0.4515.159
Sample size: 50
Built by: Benchmarks #1907
Commit: ab1f53a

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	68.51ms - 72.05ms	-	unsure 🔍 -4% - +2% -2.62ms - +1.66ms	unsure 🔍 -3% - +4% -2.10ms - +2.80ms
tip-of-tree tip-of-tree	69.55ms - 71.96ms	unsure 🔍 -2% - +4% -1.66ms - +2.62ms	-	unsure 🔍 -2% - +4% -1.25ms - +2.91ms
previous-release previous-release	68.23ms - 71.62ms	unsure 🔍 -4% - +3% -2.80ms - +2.10ms	unsure 🔍 -4% - +2% -2.91ms - +1.25ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	781.29ms - 825.85ms	-	unsure 🔍 -4% - +3% -32.51ms - +27.28ms	unsure 🔍 -5% - +3% -38.79ms - +23.49ms
tip-of-tree tip-of-tree	786.26ms - 826.12ms	unsure 🔍 -3% - +4% -27.28ms - +32.51ms	-	unsure 🔍 -4% - +3% -34.54ms - +24.47ms
previous-release previous-release	789.47ms - 832.98ms	unsure 🔍 -3% - +5% -23.49ms - +38.79ms	unsure 🔍 -3% - +4% -24.47ms - +34.54ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	846.19ms - 891.26ms	-	unsure 🔍 -3% - +4% -23.84ms - +36.98ms	unsure 🔍 -4% - +3% -38.07ms - +27.28ms
tip-of-tree tip-of-tree	841.74ms - 882.57ms	unsure 🔍 -4% - +3% -36.98ms - +23.84ms	-	unsure 🔍 -5% - +2% -43.22ms - +19.28ms
previous-release previous-release	850.46ms - 897.78ms	unsure 🔍 -3% - +4% -27.28ms - +38.07ms	unsure 🔍 -2% - +5% -19.28ms - +43.22ms	-

_{tachometer-reporter-action v2 for Benchmarks}

Fix some errors pointed out by the internal linter.

5cffb48

google-cla Bot added the cla: yes label Aug 26, 2021

bicknellr added 3 commits August 26, 2021 15:44

Add a changeset.

9344b06

Merge remote-tracking branch 'origin/main' into internal-lint

3962512

Remove an unnecessary !.

3f154bf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix some errors pointed out by the internal linter.#2096

Fix some errors pointed out by the internal linter.#2096
bicknellr wants to merge 4 commits into
mainfrom
internal-lint

bicknellr commented Aug 26, 2021

Uh oh!

changeset-bot Bot commented Aug 26, 2021 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 26, 2021 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

bicknellr commented Aug 26, 2021

Uh oh!

changeset-bot Bot commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Aug 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot Bot commented Aug 26, 2021 •

edited

Loading

github-actions Bot commented Aug 26, 2021 •

edited

Loading