[ReactiveElement] exposes `changedProperties` by sorvell · Pull Request #2722 · lit/lit

sorvell · 2022-04-12T02:30:23Z

Fixes #2721.

changeset-bot · 2022-04-12T02:30:25Z

🦋 Changeset detected

Latest commit: 5a8748c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-04-12T02:30:51Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -2% - +2% (-0.77ms - +0.59ms)
^{this-change vs tip-of-tree}

render

lit-element-list: unsure 🔍 -2% - +2% (-1.51ms - +1.90ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -3% - +2% (-1.15ms - +0.86ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +4% (-0.16ms - +0.56ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +3% (-1.21ms - +2.16ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -8% - +22% (-6.18ms - +18.37ms)
^{this-change vs tip-of-tree}

update

lit-element-list: unsure 🔍 -3% - +3% (-27.62ms - +29.17ms)
^{this-change vs tip-of-tree}
lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-2.44ms - +4.65ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +12% (-6.84ms - +48.56ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -1% - +3% (-1.89ms - +5.03ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -14% - +12% (-168.65ms - +148.94ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: unsure 🔍 -1% - +1% (-13.47ms - +13.39ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -3% - +2% (-25.08ms - +16.32ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 100.0.4896.75
Sample size: 50
Built by: Benchmarks #2707
Commit: 929cc57

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	89.88ms - 92.40ms	-	unsure 🔍 -2% - +2% -1.51ms - +1.90ms	faster ✔ 17% - 20% 19.14ms - 22.96ms
tip-of-tree tip-of-tree	89.80ms - 92.10ms	unsure 🔍 -2% - +2% -1.90ms - +1.51ms	-	faster ✔ 17% - 20% 19.40ms - 23.08ms
previous-release previous-release	110.76ms - 113.62ms	slower ❌ 21% - 25% 19.14ms - 22.96ms	slower ❌ 21% - 26% 19.40ms - 23.08ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	925.84ms - 963.64ms	-	unsure 🔍 -3% - +3% -27.62ms - +29.17ms	faster ✔ 35% - 38% 521.96ms - 572.81ms
tip-of-tree tip-of-tree	922.78ms - 965.16ms	unsure 🔍 -3% - +3% -29.17ms - +27.62ms	-	faster ✔ 35% - 38% 520.99ms - 575.33ms
previous-release previous-release	1475.12ms - 1509.13ms	slower ❌ 54% - 62% 521.96ms - 572.81ms	slower ❌ 54% - 62% 520.99ms - 575.33ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	903.57ms - 921.74ms	-	unsure 🔍 -1% - +1% -13.47ms - +13.39ms	faster ✔ 7% - 10% 70.93ms - 99.86ms
tip-of-tree tip-of-tree	902.80ms - 922.59ms	unsure 🔍 -1% - +1% -13.39ms - +13.47ms	-	faster ✔ 7% - 10% 70.37ms - 100.34ms
previous-release previous-release	986.79ms - 1009.31ms	slower ❌ 8% - 11% 70.93ms - 99.86ms	slower ❌ 8% - 11% 70.37ms - 100.34ms	-

lit-html-kitchen-sink

Browser: chrome-headless 100.0.4896.75
Sample size: 30
Built by: Benchmarks #2707
Commit: 929cc57

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	35.81ms - 37.34ms	-	unsure 🔍 -3% - +2% -1.15ms - +0.86ms	faster ✔ 12% - 18% 5.08ms - 7.86ms
tip-of-tree tip-of-tree	36.07ms - 37.37ms	unsure 🔍 -2% - +3% -0.86ms - +1.15ms	-	faster ✔ 12% - 17% 4.99ms - 7.66ms
previous-release previous-release	41.88ms - 44.21ms	slower ❌ 14% - 22% 5.08ms - 7.86ms	slower ❌ 13% - 21% 4.99ms - 7.66ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	98.17ms - 103.55ms	-	unsure 🔍 -2% - +5% -2.44ms - +4.65ms	unsure 🔍 -5% - +4% -5.46ms - +3.86ms
tip-of-tree tip-of-tree	97.44ms - 102.06ms	unsure 🔍 -5% - +2% -4.65ms - +2.44ms	-	unsure 🔍 -6% - +2% -6.35ms - +2.55ms
previous-release previous-release	97.85ms - 105.46ms	unsure 🔍 -4% - +5% -3.86ms - +5.46ms	unsure 🔍 -3% - +6% -2.55ms - +6.35ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.53ms - 32.55ms	-	unsure 🔍 -2% - +2% -0.77ms - +0.59ms	faster ✔ 10% - 15% 3.62ms - 5.61ms
tip-of-tree tip-of-tree	31.67ms - 32.58ms	unsure 🔍 -2% - +2% -0.59ms - +0.77ms	-	faster ✔ 10% - 15% 3.56ms - 5.49ms
previous-release previous-release	35.80ms - 37.50ms	slower ❌ 11% - 18% 3.62ms - 5.61ms	slower ❌ 11% - 17% 3.56ms - 5.49ms	-

lit-html-repeat

Browser: chrome-headless 100.0.4896.75
Sample size: 30
Built by: Benchmarks #2707
Commit: 929cc57

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	12.62ms - 13.16ms	-	unsure 🔍 -1% - +4% -0.16ms - +0.56ms	faster ✔ 8% - 12% 1.12ms - 1.77ms
tip-of-tree tip-of-tree	12.45ms - 12.93ms	unsure 🔍 -4% - +1% -0.56ms - +0.16ms	-	faster ✔ 9% - 13% 1.35ms - 1.95ms
previous-release previous-release	14.16ms - 14.52ms	slower ❌ 8% - 14% 1.12ms - 1.77ms	slower ❌ 10% - 16% 1.35ms - 1.95ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	405.30ms - 445.64ms	-	unsure 🔍 -2% - +12% -6.84ms - +48.56ms	faster ✔ 17% - 27% 90.34ms - 147.92ms
tip-of-tree tip-of-tree	385.62ms - 423.60ms	unsure 🔍 -11% - +1% -48.56ms - +6.84ms	-	faster ✔ 21% - 30% 112.01ms - 167.97ms
previous-release previous-release	524.05ms - 565.15ms	slower ❌ 20% - 36% 90.34ms - 147.92ms	slower ❌ 26% - 43% 112.01ms - 167.97ms	-

lit-html-template-heavy

Browser: chrome-headless 100.0.4896.75
Sample size: 50
Built by: Benchmarks #2707
Commit: 929cc57

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	64.59ms - 67.35ms	-	unsure 🔍 -2% - +3% -1.21ms - +2.16ms	faster ✔ 13% - 17% 9.78ms - 13.40ms
tip-of-tree tip-of-tree	64.52ms - 66.46ms	unsure 🔍 -3% - +2% -2.16ms - +1.21ms	-	faster ✔ 14% - 17% 10.54ms - 13.58ms
previous-release previous-release	76.38ms - 78.72ms	slower ❌ 15% - 21% 9.78ms - 13.40ms	slower ❌ 16% - 21% 10.54ms - 13.58ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	143.61ms - 148.81ms	-	unsure 🔍 -1% - +3% -1.89ms - +5.03ms	faster ✔ 12% - 16% 19.97ms - 27.96ms
tip-of-tree tip-of-tree	142.35ms - 146.93ms	unsure 🔍 -3% - +1% -5.03ms - +1.89ms	-	faster ✔ 13% - 17% 21.73ms - 29.34ms
previous-release previous-release	167.14ms - 173.21ms	slower ❌ 13% - 19% 19.97ms - 27.96ms	slower ❌ 15% - 20% 21.73ms - 29.34ms	-

reactive-element-list

Browser: chrome-headless 100.0.4896.75
Sample size: 50
Built by: Benchmarks #2707
Commit: 929cc57

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	82.90ms - 100.06ms	-	unsure 🔍 -8% - +22% -6.18ms - +18.37ms	unsure 🔍 -5% - +26% -3.25ms - +20.88ms
tip-of-tree tip-of-tree	76.61ms - 94.16ms	unsure 🔍 -20% - +6% -18.37ms - +6.18ms	-	unsure 🔍 -12% - +18% -9.49ms - +14.93ms
previous-release previous-release	74.19ms - 91.15ms	unsure 🔍 -22% - +3% -20.88ms - +3.25ms	unsure 🔍 -17% - +11% -14.93ms - +9.49ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	1110.06ms - 1335.60ms	-	unsure 🔍 -14% - +12% -168.65ms - +148.94ms	unsure 🔍 -18% - +6% -243.61ms - +82.00ms
tip-of-tree tip-of-tree	1120.89ms - 1344.49ms	unsure 🔍 -12% - +14% -148.94ms - +168.65ms	-	unsure 🔍 -18% - +7% -233.08ms - +91.19ms
previous-release previous-release	1186.21ms - 1421.06ms	unsure 🔍 -7% - +20% -82.00ms - +243.61ms	unsure 🔍 -8% - +19% -91.19ms - +233.08ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	936.07ms - 965.19ms	-	unsure 🔍 -3% - +2% -25.08ms - +16.32ms	unsure 🔍 -2% - +2% -22.28ms - +20.78ms
tip-of-tree tip-of-tree	940.29ms - 969.72ms	unsure 🔍 -2% - +3% -16.32ms - +25.08ms	-	unsure 🔍 -2% - +3% -18.01ms - +25.26ms
previous-release previous-release	935.52ms - 967.24ms	unsure 🔍 -2% - +2% -20.78ms - +22.28ms	unsure 🔍 -3% - +2% -25.26ms - +18.01ms	-

_{tachometer-reporter-action v2 for Benchmarks}

Steven Orvell added 2 commits April 11, 2022 19:15

[ReactiveElement] exposes

4f2e1c0

Add changeset

5a8748c

sorvell requested a review from justinfagnani as a code owner April 12, 2022 02:30

sorvell requested a review from kevinpschaaf April 12, 2022 02:30

sorvell marked this pull request as draft July 25, 2022 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ReactiveElement] exposes `changedProperties`#2722

[ReactiveElement] exposes `changedProperties`#2722
sorvell wants to merge 2 commits into
mainfrom
changedProperties-protected

sorvell commented Apr 12, 2022

Uh oh!

changeset-bot Bot commented Apr 12, 2022

Uh oh!

github-actions Bot commented Apr 12, 2022 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sorvell commented Apr 12, 2022

Uh oh!

changeset-bot Bot commented Apr 12, 2022

🦋 Changeset detected

Uh oh!

github-actions Bot commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Apr 12, 2022 •

edited

Loading