[infra] exploratory fix Safari breaking in scoped-registry-mixin test by AndrewJakubowicz · Pull Request #3297 · lit/lit

AndrewJakubowicz · 2022-09-22T17:46:59Z

Context

Exploratory fix for the following error in CI:

../labs/scoped-registry-mixin/development/test/scoped-registry-mixin_test.js:

 🚧 Browser logs on macOS 10.15 Safari latest:
      TypeError: Importing a module script failed.

 ❌ Could not import your test module. Check the browser logs or open the browser in debug mode for more information.  (failed on macOS 1

Hypothesis is that when we shouldn't be testing - the test fixtures execute and break Safari in Sauce.

changeset-bot · 2022-09-22T17:47:02Z

⚠️ No Changeset found

Latest commit: d2d2ac7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-09-22T17:47:21Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -3% - +0% (-0.67ms - +0.12ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 70.69ms - 74.41ms
lit-html-kitchen-sink: unsure 🔍 -1% - +6% (-0.39ms - +1.49ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -2% - +2% (-0.22ms - +0.22ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -4% - +1% (-1.94ms - +0.63ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +2% (-0.39ms - +1.00ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 676.91ms - 688.69ms
lit-html-kitchen-sink: unsure 🔍 -3% - +2% (-2.44ms - +1.81ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +0% (-3.74ms - +1.30ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +2% (-2.76ms - +1.78ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-6.45ms - +7.63ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 687.36ms - 697.73ms
reactive-element-list: unsure 🔍 -1% - +2% (-8.63ms - +15.87ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 105.0.5195.102
Sample size: 50
Built by: Benchmarks #3807
Commit: 3e793d8

render

Version	Avg time	vs
	70.69ms - 74.41ms	-

update

Version	Avg time	vs
	676.91ms - 688.69ms	-

update-reflect

Version	Avg time	vs
	687.36ms - 697.73ms	-

lit-html-kitchen-sink

Browser: chrome-headless 105.0.5195.102
Sample size: 30
Built by: Benchmarks #3807
Commit: 3e793d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	26.73ms - 28.58ms	-	unsure 🔍 -1% - +6% -0.39ms - +1.49ms	unsure 🔍 -2% - +5% -0.66ms - +1.26ms
tip-of-tree tip-of-tree	26.96ms - 27.26ms	unsure 🔍 -5% - +1% -1.49ms - +0.39ms	-	unsure 🔍 -2% - +0% -0.54ms - +0.04ms
previous-release previous-release	27.11ms - 27.60ms	unsure 🔍 -5% - +2% -1.26ms - +0.66ms	unsure 🔍 -0% - +2% -0.04ms - +0.54ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	76.13ms - 79.25ms	-	unsure 🔍 -3% - +2% -2.44ms - +1.81ms	unsure 🔍 -1% - +4% -1.08ms - +2.86ms
tip-of-tree tip-of-tree	76.56ms - 79.45ms	unsure 🔍 -2% - +3% -1.81ms - +2.44ms	-	unsure 🔍 -1% - +4% -0.68ms - +3.08ms
previous-release previous-release	75.61ms - 78.01ms	unsure 🔍 -4% - +1% -2.86ms - +1.08ms	unsure 🔍 -4% - +1% -3.08ms - +0.68ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	23.57ms - 24.00ms	-	unsure 🔍 -3% - +0% -0.67ms - +0.12ms	unsure 🔍 -1% - +1% -0.32ms - +0.26ms
tip-of-tree tip-of-tree	23.73ms - 24.39ms	unsure 🔍 -1% - +3% -0.12ms - +0.67ms	-	unsure 🔍 -1% - +3% -0.14ms - +0.62ms
previous-release previous-release	23.63ms - 24.01ms	unsure 🔍 -1% - +1% -0.26ms - +0.32ms	unsure 🔍 -3% - +1% -0.62ms - +0.14ms	-

lit-html-repeat

Browser: chrome-headless 105.0.5195.102
Sample size: 30
Built by: Benchmarks #3807
Commit: 3e793d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.16ms - 10.44ms	-	unsure 🔍 -2% - +2% -0.22ms - +0.22ms	unsure 🔍 -1% - +2% -0.14ms - +0.24ms
tip-of-tree tip-of-tree	10.13ms - 10.47ms	unsure 🔍 -2% - +2% -0.22ms - +0.22ms	-	unsure 🔍 -2% - +3% -0.17ms - +0.26ms
previous-release previous-release	10.12ms - 10.39ms	unsure 🔍 -2% - +1% -0.24ms - +0.14ms	unsure 🔍 -3% - +2% -0.26ms - +0.17ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	265.06ms - 268.52ms	-	unsure 🔍 -1% - +0% -3.74ms - +1.30ms	unsure 🔍 -1% - +1% -4.01ms - +2.06ms
tip-of-tree tip-of-tree	266.18ms - 269.85ms	unsure 🔍 -0% - +1% -1.30ms - +3.74ms	-	unsure 🔍 -1% - +1% -2.84ms - +3.34ms
previous-release previous-release	265.28ms - 270.26ms	unsure 🔍 -1% - +2% -2.06ms - +4.01ms	unsure 🔍 -1% - +1% -3.34ms - +2.84ms	-

lit-html-template-heavy

Browser: chrome-headless 105.0.5195.102
Sample size: 50
Built by: Benchmarks #3807
Commit: 3e793d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	52.17ms - 53.35ms	-	unsure 🔍 -4% - +1% -1.94ms - +0.63ms	unsure 🔍 -1% - +2% -0.49ms - +1.11ms
tip-of-tree tip-of-tree	52.27ms - 54.55ms	unsure 🔍 -1% - +4% -0.63ms - +1.94ms	-	unsure 🔍 -1% - +4% -0.30ms - +2.22ms
previous-release previous-release	51.91ms - 52.99ms	unsure 🔍 -2% - +1% -1.11ms - +0.49ms	unsure 🔍 -4% - +1% -2.22ms - +0.30ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	113.67ms - 116.95ms	-	unsure 🔍 -2% - +2% -2.76ms - +1.78ms	unsure 🔍 -2% - +2% -2.82ms - +1.99ms
tip-of-tree tip-of-tree	114.22ms - 117.37ms	unsure 🔍 -2% - +2% -1.78ms - +2.76ms	-	unsure 🔍 -2% - +2% -2.29ms - +2.44ms
previous-release previous-release	113.96ms - 117.49ms	unsure 🔍 -2% - +2% -1.99ms - +2.82ms	unsure 🔍 -2% - +2% -2.44ms - +2.29ms	-

reactive-element-list

Browser: chrome-headless 105.0.5195.102
Sample size: 50
Built by: Benchmarks #3807
Commit: 3e793d8

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	51.22ms - 52.18ms	-	unsure 🔍 -1% - +2% -0.39ms - +1.00ms	unsure 🔍 -1% - +1% -0.69ms - +0.69ms
tip-of-tree tip-of-tree	50.89ms - 51.89ms	unsure 🔍 -2% - +1% -1.00ms - +0.39ms	-	unsure 🔍 -2% - +1% -1.02ms - +0.39ms
previous-release previous-release	51.21ms - 52.20ms	unsure 🔍 -1% - +1% -0.69ms - +0.69ms	unsure 🔍 -1% - +2% -0.39ms - +1.02ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	682.68ms - 692.00ms	-	unsure 🔍 -1% - +1% -6.45ms - +7.63ms	unsure 🔍 -1% - +1% -6.32ms - +7.32ms
tip-of-tree tip-of-tree	681.47ms - 692.03ms	unsure 🔍 -1% - +1% -7.63ms - +6.45ms	-	unsure 🔍 -1% - +1% -7.35ms - +7.18ms
previous-release previous-release	681.85ms - 691.82ms	unsure 🔍 -1% - +1% -7.32ms - +6.32ms	unsure 🔍 -1% - +1% -7.18ms - +7.35ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	781.16ms - 797.50ms	-	unsure 🔍 -1% - +2% -8.63ms - +15.87ms	unsure 🔍 -2% - +1% -17.82ms - +7.13ms
tip-of-tree tip-of-tree	776.59ms - 794.83ms	unsure 🔍 -2% - +1% -15.87ms - +8.63ms	-	unsure 🔍 -3% - +1% -22.08ms - +4.15ms
previous-release previous-release	785.25ms - 804.10ms	unsure 🔍 -1% - +2% -7.13ms - +17.82ms	unsure 🔍 -1% - +3% -4.15ms - +22.08ms	-

_{tachometer-reporter-action v2 for Benchmarks}

test fix Sauce Safari latest breaking on CI

d2d2ac7

AndrewJakubowicz changed the title ~~[infra] exploratory fix Sauce Safari latest breaking on CI~~ [infra] exploratory fix Safari breaking in scoped-registry-mixin test Sep 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[infra] exploratory fix Safari breaking in scoped-registry-mixin test#3297

[infra] exploratory fix Safari breaking in scoped-registry-mixin test#3297
AndrewJakubowicz wants to merge 1 commit into
mainfrom
test-declaration-behind-cantest-flag

AndrewJakubowicz commented Sep 22, 2022

Uh oh!

changeset-bot Bot commented Sep 22, 2022

Uh oh!

github-actions Bot commented Sep 22, 2022 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

AndrewJakubowicz commented Sep 22, 2022

Context

Uh oh!

changeset-bot Bot commented Sep 22, 2022

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Sep 22, 2022 •

edited

Loading