Multi-Windows#2140
Open
adamharrison wants to merge 27 commits into
Open
Conversation
… it between plugin and main, and we should use the command system if possible. Streamlined language. Unified predicates. Fixed up some minor issues. Readded this menu bind. Ensured that context menu command works even without x and y. Cleaned up treeview rework, and incoporated Guldo's comments.
Beginning moving of stuff to multi-window. Fixed a number of bugs. Need to do contextmenu rework first. Fixes. Solidified command structure. Changing most stuff over to root_view.
Fixed some issue. Cleaned up older multi-window stuff. Passed window to keymap. Fix a few things. Treeview changes. Fixed autocomplete and window restoration. Fixed nag_view. Removed all instances of core references to views.
This fixes display issues when the display scaling factor is not 1.0 on Linux Wayland.
A mouse wheel event has a float value to indicate the "speed". This value is passed to Lua as an integer. In the case of very low mouse wheel sensitivities, the speed value can be below 1, which got converted to zero for the lua side. This effectively disabled the mouse wheel. The problem does not exist with X11 because the mouse wheel speed is an integer - at least as provided by SDL3. The fix is to pass the float value to Lua instead.
The bug was: when screen scaling was different from 1, the window size would not be restored properly after closing and reopening. It would be scaled by the screen scaling factor. The fix is to make f_renwin_set_size take physical pixels as input instead of scaled ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2122 and #2076.
Adds in multi-window support.