Fix python colon in strings#2193
Open
1ul1 wants to merge 2 commits into
Open
Conversation
- Remove fragile one-liner patterns that scan to <<:>> and can terminate inside strings, causing the rest of the file to be registered as an unterminated string. - Add a targeted pattern for catching comments <<#>> after <<:>>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original Python syntax relied on block-header rules that terminated at the first colon, which broke highlighting when colons appeared inside strings.
After removing those patterns, a top-level type-annotation rule incorrectly treated block colons as type contexts, breaking keyword/function highlighting.
I removed these, and everything works as expected, except type hints which are treated as normal text. But this is the case even with the original plugin (line 41 in the photo), which only treated them correctly when inside blocks (line 43).
Additionally, removing these lines fixes another problem: print() and returns were colored weirdly (either as functions or as variables with no reason (lines 56 & 58).
I attached a picture that shows the results:
Thanks for looking over this!
Fixes #2190