[OM] Remove Pure from ObjectOp to preserve identity #9303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `Pure` trait from `om.object`. With the op marked pure, the CSE pass will combine instances of the same class into a single instance. This is problematic, since users may expect distinct instances of the same class to be preserved as two separate instances instead of being deduplicated. Instead, add the `MemAlloc` trait to the result of the `ObjectOp`. This causes the op to no longer CSE, but it allows unused objects to be erased.
mikeurbach
approved these changes
Dec 4, 2025
Contributor
mikeurbach
left a comment
There was a problem hiding this comment.
Thanks for sussing this out and fixing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
Puretrait fromom.object. With the op marked pure, the CSE pass will combine instances of the same class into a single instance. This is problematic, since users may expect distinct instances of the same class to be preserved as two separate instances instead of being deduplicated.Instead, add the
MemAlloctrait to the result of theObjectOp. This causes the op to no longer CSE, but it allows unused objects to be erased.