Repository navigation
Fix upvote arrow not showing as orange in /inbox/all (fixes #2128) - #2210
Open
oyamairishitomi wants to merge 1 commit into
Open
oyamairishitomi wants to merge 1 commit into
oyamairishitomi wants to merge 1 commit into
Conversation
Member
|
Thanks for taking this on. The way this works by side effect is pretty subtle, could you remove the misleading |
Member
|
...and sorry about the build failures, they're unrelated to your work and will disappear if you rebase onto |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vote arrow for already-voted comments in the comment list did not appear orange when /inbox/all was loaded. The issue was that CommentVoteHydrator was not being enumerated, even though it implements Enumerable. Added .to_a to CommentVoteHydrator.new(comment_notifications, @user) in the apply_current_vote method.
Fixes #2128