Repository navigation
Change read mode to immediately stop consuming lines when shutting down - #322
Merged
edmocosta merged 2 commits intoDec 13, 2023
Merged
Conversation
edmocosta
force-pushed
the
change-read-mode-shutdown
branch
from
December 5, 2023 14:36
ce0b13c to
087b401
Compare
edmocosta
marked this pull request as ready for review
December 7, 2023 09:11
jsvd
approved these changes
Dec 13, 2023
jsvd
left a comment
Member
There was a problem hiding this comment.
LGTM.
I've confirmed that this change allows Logstash to terminate much sooner, on each line instead on each loop (which can be hundreds of lines).
I've also tested with multiple reads and multiple shutdowns/restarts that no data was lost or duplicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the read mode to immediately stop consuming buffered lines when the pipeline shutdown is requested.
Closes: #323