Repository navigation
Conversation
Ensure that path entries containing '/' characters, such as those using date math are handled correctly. Also adds an integration test target using logstash source
Member
Author
|
@jsvd - This PR now has integration tests that will test ilm (and other elasticsearch functions) against latest logstash source rather than |
Member
Author
|
@jsvd is this good to go? |
Member
|
@robbavey sorry, not yet, I'm testing it today |
jsvd
approved these changes
Jan 29, 2019
jsvd
left a comment
Member
There was a problem hiding this comment.
LGTM, tested a few use cases manually, the settings were respected and aliases configured and correctly written to. 👍
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 29, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that path entries containing '/' characters, such as those using
date math are handled correctly.
Also adds an integration test target using logstash source