Skip to content

[Doc]Add note about _type setting change from doc to _doc - #884

Merged
karenzone merged 3 commits into
logstash-plugins:masterfrom
karenzone:add-docs-note
Mar 27, 2020
Merged

karenzone merged 3 commits into
logstash-plugins:masterfrom
karenzone:add-docs-note

Conversation

@karenzone

Copy link
Copy Markdown
Contributor

Call out _type change from doc to _doc in documentation

@karenzone karenzone added the docs label Oct 7, 2019
@karenzone
karenzone requested a review from robbavey October 7, 2019 21:48
@karenzone
karenzone removed the request for review from robbavey October 9, 2019 19:58
@karenzone

Copy link
Copy Markdown
Contributor Author

@yaauie @jsvd Am I capturing the right messaging here? I mentioned the upgrade implications, but I'm wondering if there's more the user would want/need to know.

@elasticsearch-bot elasticsearch-bot self-assigned this Mar 24, 2020
@yaauie yaauie assigned yaauie and unassigned elasticsearch-bot Mar 25, 2020

@yaauie yaauie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the best way to communicate the nuance here in a way that is immediately actionable, but I've taken a stab at sharing context and possibly rewriting the result.

Comment thread docs/index.asciidoc Outdated
@karenzone karenzone self-assigned this Mar 26, 2020
karenzone and others added 2 commits March 26, 2020 13:03
Co-Authored-By: Ry Biesemeyer <yaauie@users.noreply.github.com>
@karenzone
karenzone force-pushed the add-docs-note branch 3 times, most recently from 70d871e to 42d75af Compare March 26, 2020 18:40
@karenzone

Copy link
Copy Markdown
Contributor Author

@yaauie Thanks for the assist.

@karenzone
karenzone requested a review from yaauie March 26, 2020 18:43

@yaauie yaauie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@karenzone
karenzone merged commit 7ba6acc into logstash-plugins:master Mar 27, 2020
@karenzone
karenzone deleted the add-docs-note branch March 27, 2020 14:36
@karenzone

Copy link
Copy Markdown
Contributor Author

PUBLISHED:
Screen Shot 2020-03-27 at 12 04 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants