fix(core): log tenant initialization errors#9143
Merged
simeng-li merged 1 commit intoJul 10, 2026
Merged
Conversation
NgoQuocViet2001
requested review from
gao-sun,
simeng-li and
wangsijie
as code owners
July 2, 2026 09:58
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/app/init.test.ts | 📈 +1.23 KB |
| packages/core/src/app/init.ts | 📈 +116 Bytes |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures tenant initialization failures are logged to the request-scoped console (so they appear in stdout/stderr for self-hosted deployments) and adds a regression test covering the tenantPool.get() rejection path, addressing #5807.
Changes:
- Log
tenantPool.get()initialization failures via the request console before returning an error response. - Add a unit test that verifies the error path returns 500 and reports the exception.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/app/init.ts | Logs tenant initialization errors using the request context console and continues reporting them to App Insights |
| packages/core/src/app/init.test.ts | Adds a regression test for the tenantPool.get() rejection path and expected logging/telemetry behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charIeszhao
approved these changes
Jul 2, 2026
charIeszhao
left a comment
Member
There was a problem hiding this comment.
Reviewed by automation; no correctness issues found.
simeng-li
force-pushed
the
ngoquocviet2001-log-tenant-init-errors
branch
from
July 8, 2026 06:40
47f7d94 to
5870ff7
Compare
wangsijie
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tenantPool.get()rejection path.Closes #5807
Testing
Unit tests