fix: 修正拼写错误“oltphttp”->“otlphttp” - #2121
Conversation
📝 WalkthroughWalkthroughThe metrics exporter type spelling is corrected from ChangesMetrics exporter configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryCorrects the OTLP HTTP metrics exporter identifier from the invalid
Confidence Score: 5/5The PR appears safe to merge because all three changes consistently correct the exporter value to the spelling accepted by the metrics implementation. The updated examples now use
|
| Filename | Overview |
|---|---|
| config.example.yml | Corrects the example metrics exporter type to the valid otlphttp identifier. |
| docs/en/deployment/configuration.md | Corrects the English metrics configuration example to match the supported exporter type. |
| docs/zh/deployment/configuration.md | Corrects the Chinese metrics configuration example to match the supported exporter type. |
Reviews (1): Last reviewed commit: "fix: 修正拼写错误“oltphttp”->“otlphttp”" | Re-trigger Greptile
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config.example.yml`:
- Line 147: Update the exporter-type comments at config.example.yml lines
147-147, docs/en/deployment/configuration.md lines 299-299, and
docs/zh/deployment/configuration.md lines 300-300 to list stdout, otlpgrpc, and
otlphttp, matching the supported types in internal/metrics/provider.go.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b2cad99-96e1-4f0e-9d99-750c88a3a704
📒 Files selected for processing (3)
config.example.ymldocs/en/deployment/configuration.mddocs/zh/deployment/configuration.md
| enabled: false # Enable metrics collection (env: AXONHUB_METRICS_ENABLED) | ||
| exporter: | ||
| type: "oltphttp" # Metrics exporter type: prometheus, console (env: AXONHUB_METRICS_EXPORTER_TYPE) | ||
| type: "otlphttp" # Metrics exporter type: prometheus, console (env: AXONHUB_METRICS_EXPORTER_TYPE) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Keep all exporter-type documentation consistent.
The three changed examples use otlphttp, but their comments still list prometheus and console. Replace those lists with stdout, otlpgrpc, and otlphttp, which match internal/metrics/provider.go.
config.example.yml#L147-L147: update the inline exporter-type comment.docs/en/deployment/configuration.md#L299-L299: update the English exporter-type comment.docs/zh/deployment/configuration.md#L300-L300: update the Chinese documentation comment.
📍 Affects 3 files
config.example.yml#L147-L147(this comment)docs/en/deployment/configuration.md#L299-L299docs/zh/deployment/configuration.md#L300-L300
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@config.example.yml` at line 147, Update the exporter-type comments at
config.example.yml lines 147-147, docs/en/deployment/configuration.md lines
299-299, and docs/zh/deployment/configuration.md lines 300-300 to list stdout,
otlpgrpc, and otlphttp, matching the supported types in
internal/metrics/provider.go.
* upstream/unstable: (21 commits) fix: admin page permission protect (looplj#2138) chore: make zh default readme chore: sync model developers data (looplj#2131) feat: model load balance strategy (looplj#2127) feat(permissions): align project roles with UI access (looplj#2095) fix(responses): scope fallback prompt_cache_key per conversation (looplj#2031) fix(responses): merge consecutive function/custom tool calls into one assistant message (looplj#2114) feat: add per-channel API key rule actions (looplj#2120) feat: add configurable max_multipart_memory for backup restore (looplj#2126) fix(responses): keep images in tool results instead of dropping them (looplj#2117) fix(frontend): load theme fonts (looplj#2122) fix: 修正拼写错误“oltphttp”->“otlphttp” (looplj#2121) fix(analytics): support MySQL for channel stats (looplj#2123) fix: reuse bundled Windows binary (looplj#2119) fix(frontend): improve requests table mobile responsiveness (looplj#2118) feat: check new beta version, close looplj#2097 (looplj#2111) feat: response with trace headers, close looplj#2100 (looplj#2107) feat: backup & restore systems config, close looplj#2101 (looplj#2104) fix(gemini): preserve file data MIME type for Vertex (looplj#2091) feat: add provider quota collection controls (looplj#2103) ...
Summary by CodeRabbit
Bug Fixes
otlphttp, ensuring valid configuration.Documentation