Skip to content

fix: 修正拼写错误“oltphttp”->“otlphttp” - #2121

Merged
looplj merged 1 commit into
looplj:unstablefrom
bookshiyi:fix-otlphttp-spell-error
Aug 1, 2026
Merged

looplj merged 1 commit into
looplj:unstablefrom
bookshiyi:fix-otlphttp-spell-error

Conversation

@bookshiyi

@bookshiyi bookshiyi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the metrics exporter type value to otlphttp, ensuring valid configuration.
  • Documentation

    • Updated English and Chinese configuration examples to use the corrected exporter type.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The metrics exporter type spelling is corrected from oltphttp to otlphttp in the example configuration and English and Chinese deployment documentation.

Changes

Metrics exporter configuration

Layer / File(s) Summary
Correct the exporter type examples
config.example.yml, docs/*/deployment/configuration.md
The example configuration and deployment documentation now use otlphttp for the metrics exporter type.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: looplj, wangyx657211334

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the spelling correction from oltphttp to otlphttp, which matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Corrects the OTLP HTTP metrics exporter identifier from the invalid oltphttp spelling to the implementation-supported otlphttp spelling.

  • Updates the example YAML configuration.
  • Keeps the English and Chinese deployment documentation consistent with the corrected configuration value.

Confidence Score: 5/5

The PR appears safe to merge because all three changes consistently correct the exporter value to the spelling accepted by the metrics implementation.

The updated examples now use otlphttp, matching the metrics configuration validation and exporter selection logic, with no behavioral regression identified.

Important Files Changed

Filename Overview
config.example.yml Corrects the example metrics exporter type to the valid otlphttp identifier.
docs/en/deployment/configuration.md Corrects the English metrics configuration example to match the supported exporter type.
docs/zh/deployment/configuration.md Corrects the Chinese metrics configuration example to match the supported exporter type.

Reviews (1): Last reviewed commit: "fix: 修正拼写错误“oltphttp”->“otlphttp”" | Re-trigger Greptile

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config.example.yml`:
- Line 147: Update the exporter-type comments at config.example.yml lines
147-147, docs/en/deployment/configuration.md lines 299-299, and
docs/zh/deployment/configuration.md lines 300-300 to list stdout, otlpgrpc, and
otlphttp, matching the supported types in internal/metrics/provider.go.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b2cad99-96e1-4f0e-9d99-750c88a3a704

📥 Commits

Reviewing files that changed from the base of the PR and between 9d4b2a8 and 6f673f3.

📒 Files selected for processing (3)
  • config.example.yml
  • docs/en/deployment/configuration.md
  • docs/zh/deployment/configuration.md

Comment thread config.example.yml
enabled: false # Enable metrics collection (env: AXONHUB_METRICS_ENABLED)
exporter:
type: "oltphttp" # Metrics exporter type: prometheus, console (env: AXONHUB_METRICS_EXPORTER_TYPE)
type: "otlphttp" # Metrics exporter type: prometheus, console (env: AXONHUB_METRICS_EXPORTER_TYPE)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Keep all exporter-type documentation consistent.

The three changed examples use otlphttp, but their comments still list prometheus and console. Replace those lists with stdout, otlpgrpc, and otlphttp, which match internal/metrics/provider.go.

  • config.example.yml#L147-L147: update the inline exporter-type comment.
  • docs/en/deployment/configuration.md#L299-L299: update the English exporter-type comment.
  • docs/zh/deployment/configuration.md#L300-L300: update the Chinese documentation comment.
📍 Affects 3 files
  • config.example.yml#L147-L147 (this comment)
  • docs/en/deployment/configuration.md#L299-L299
  • docs/zh/deployment/configuration.md#L300-L300
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config.example.yml` at line 147, Update the exporter-type comments at
config.example.yml lines 147-147, docs/en/deployment/configuration.md lines
299-299, and docs/zh/deployment/configuration.md lines 300-300 to list stdout,
otlpgrpc, and otlphttp, matching the supported types in
internal/metrics/provider.go.

@looplj
looplj merged commit 31be400 into looplj:unstable Aug 1, 2026
2 checks passed
@bookshiyi
bookshiyi deleted the fix-otlphttp-spell-error branch August 1, 2026 05:43
caolib added a commit to caolib/axonhub that referenced this pull request Aug 4, 2026
* upstream/unstable: (21 commits)
  fix: admin page permission  protect (looplj#2138)
  chore: make zh default readme
  chore: sync model developers data (looplj#2131)
  feat: model load balance strategy (looplj#2127)
  feat(permissions): align project roles with UI access (looplj#2095)
  fix(responses): scope fallback prompt_cache_key per conversation (looplj#2031)
  fix(responses): merge consecutive function/custom tool calls into one assistant message (looplj#2114)
  feat: add per-channel API key rule actions (looplj#2120)
  feat: add configurable max_multipart_memory for backup restore (looplj#2126)
  fix(responses): keep images in tool results instead of dropping them (looplj#2117)
  fix(frontend): load theme fonts (looplj#2122)
  fix: 修正拼写错误“oltphttp”->“otlphttp” (looplj#2121)
  fix(analytics): support MySQL for channel stats (looplj#2123)
  fix: reuse bundled Windows binary (looplj#2119)
  fix(frontend): improve requests table mobile responsiveness (looplj#2118)
  feat: check new beta version, close looplj#2097 (looplj#2111)
  feat: response with trace headers, close looplj#2100 (looplj#2107)
  feat: backup & restore systems config, close looplj#2101 (looplj#2104)
  fix(gemini): preserve file data MIME type for Vertex (looplj#2091)
  feat: add provider quota collection controls (looplj#2103)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants