callouts with classes are now rendered correctly by Basster · Pull Request #8 · lorenzo/pinky

Basster · 2018-09-18T11:35:58Z

The current version of the callouts with classes is erroneous:

<table class="primary callout">
  <tr>
    <th class="callout-inner">
      <p>foobar</p>
    </th>
    <th class="expander"></th>
  </tr>
</table>

According to https://foundation.zurb.com/emails/docs/callout.html, callouts with classes should produce the following html:

<callout class="primary">
  <p>foobar</p>
</callout>

produces

<table class="callout">
  <tr>
    <th class="callout-inner primary">
      <p>foobar</p>
    </th>
    <th class="expander"></th>
  </tr>
</table>

This PR fixes this...

Nevertheless callout template was duplicated on the inky.xsl.

lorenzo · 2018-09-18T14:16:34Z

Thanks!

callouts with classes are now rendered correctly, according to https:…

84a24a3

…//foundation.zurb.com/emails/docs/callout.html

lorenzo merged commit 5694315 into lorenzo:master Sep 18, 2018

Navigation Menu