Repository navigation
Feed Overture heights into OSM data - #1271
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the Overture Buildings integration to enrich OSM-derived building footprints with Overture’s conflated height / floor-count attributes (when OSM lacks both tags), while still using Overture for additional non-OSM footprints and updating attribution text accordingly.
Changes:
- Add OSM back-reference parsing (
sources[].record_id) and anOvertureHintsmechanism to applyheight/building:levelsadditively to OSM buildings. - Change the Overture fetch API to return both new footprints and OSM attribute hints, and apply hints during CLI/GUI generation before merging footprints.
- Update the 3D preview fetch path and add license attribution text for the Overture Buildings integration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/preview_3d.rs | Adjusts preview path to the new Overture collection return type and keeps full OSM-sourced coverage for preview. |
| src/overture.rs | Introduces OSM back-reference parsing, hint collection, and additive application of heights/levels; updates fetch APIs and adds tests. |
| src/main.rs | Updates CLI generation to use the new OvertureData return type and apply Overture hints to OSM buildings. |
| src/gui/js/license.js | Adds Overture Buildings attribution text to the GUI license modal. |
| src/gui.rs | Updates GUI generation flow to use OvertureData and apply Overture hints before merging footprints. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
⏱️ Benchmark run finished in 0m 47s 📈 Compared against baseline: 18s time, 1160 MB memory 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-08-16 17:35:59 UTC You can retrigger the benchmark by commenting |
No description provided.