validate convolve kernel values are numbers - #4549
Merged
Merged
Conversation
Owner
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convolve validates the kernel width, height and that the flattened kernel array has the expected length, but never checks the entries themselves are numbers, unlike the sibling affine, linear and recomb operators which all guard their input with is.number. a NaN entry therefore passes straight through to the native convolution mask and produces a silently wrong (all-zero) result, whilst a string or null entry surfaces only the vague "A number was expected" from the native layer rather than the usual invalid-parameter error. the safer behaviour is to reject a malformed kernel up front, so this adds the same per-entry is.number check to the existing kernel validation, keeping the contract consistent with its siblings. the added tests cover the string and NaN cases, both of which slip through today.