Repository navigation
Conversation
This PR patches a HIGH-severity vulnerability in the Key Derivation Function (KDF) pipeline where unbounded, caller-provided scrypt parameters could lead to CPU and memory resource exhaustion (Denial of Service).
Key Changes:Runtime Parameter Validation: Introduced validateScryptParams to strictly bound and enforce limits on N (must be a power of two between $2^{10}$ and $2^{17}$), r (max 8), and p (max 2) before allocating any work.
Fail-Closed Execution: The boundary now rejects values outside these limits by throwing a typed RangeError before calling scrypt, safely rejecting tampered metadata from persisted vaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches a HIGH-severity vulnerability in the Key Derivation Function (KDF) pipeline where unbounded, caller-provided scrypt parameters could lead to CPU and memory resource exhaustion (Denial of Service).
Key Changes:Runtime Parameter Validation: Introduced validateScryptParams to strictly bound and enforce limits on N (must be a power of two between$2^{10}$ and $2^{17}$ ), r (max 8), and p (max 2) before allocating any work.
Fail-Closed Execution: The boundary now rejects values outside these limits by throwing a typed RangeError before calling scrypt, safely rejecting tampered metadata from persisted vaults.