Skip download #606
Skip download #606
Conversation
docs/api.md
Outdated
docs/api.md
Outdated
install.js
Outdated
There was a problem hiding this comment.
any reason not to use process.env.PUPPETEER_SKIP_CHROMIUM_DOWNLOAD?
There was a problem hiding this comment.
Property access with string literals is done to trick type linter and avoid the ERROR: PUPPETEER_SKIP_CHROMIUM_DOWNLOAD is never defined on process.env object. That's a habbit from devtools codebase.
Done.
install.js
Outdated
There was a problem hiding this comment.
Not sure this should say "Warning". Users opt-in to it. How about:
console.log('**INFO** Skipping Chromium download. "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" environment variable was found.');
83d3200 to
ae3205d
Compare
|
Still related to this, I am new and it take couple of minutes to figure out how to set |
|
@brutalcrozt instead of adding this example, would you mind sending a PR that links to the wiki page in the documentation? This would help others who don't know what's an environment variable. |
|
@aslushnikov Yes, that was kind of response which i expected. Recently my PR are rejected because miss match the expectation, so i like to make a small comment to prevent that. 😄 , Thanks |
|
@brutalcrozt I still can't figure out how to do it. Can i ask for your help ? |
This patch starts skipping chromium download when PUPPETEER_SKIP_CHROMIUM_DOWNLOAD env variable is set.