Throw an error when Chromium download is failed #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would play nice with #606 Codewise, we should probably process.exit(1) to terminate the script with non-zero exit code |
|
We can do the process.exit(1) from the onError function |
|
@homaily any updates on this? I'm very interested in this PR. |
|
@aslushnikov Sorry didn't get your point. Do you want the process.exit in the onError on int the place of throw Error? |
aslushnikov
reviewed
Sep 1, 2017
| .catch(err => err) | ||
| .catch(err => { throw err; }) | ||
| .then(() => { | ||
| if (fs.existsSync(zipPath)) |
There was a problem hiding this comment.
Unfortunately, there's no "finally" in promise chains, so I'd fake it like this:
.catch(err => err)
.then(err => {
if (fs.existsSync(zipPath))
fs.unlinkSync(zipPath);
if (err)
throw err;
});This way we'll throw an error and cleanup zip if any
There was a problem hiding this comment.
Much better love it. I've updated my code to do that.
Finishing the promise chain to remove the partially downloaded zip file (if exists)
|
You're welcome Andrey. Appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When Chromium download is failed (no internet connection for example) downloadRevision will not emit an error and therefore onError function in the install file will not be triggered and the user will not see the message:
I'm using Node v6.11.2