feat(Page): teach Page.setContent to wait for resources to load #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds "options" parameter to the `page.setContent` method. The parameter is the same as a navigation parameter and allows to specify maximum timeout to wait for resources to be loaded, as well as to describe events that should be emitted before the setContent operation would be considered successful. Fixes puppeteer#728.
docs/api.md
Outdated
| - returns: <[Promise]> | ||
| - `options` <[Object]> Navigation parameters which might have the following properties: | ||
| - `timeout` <[number]> Maximum navigation time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. | ||
| - `waitUntil` <[string]|[Array]<[string]>> When to consider setting content complete, defaults to `load`. Given an array of event strings, setting content is considered to be successful after all events have been fired. Events Can be either: |
There was a problem hiding this comment.
small typo here and other places
Can can
JoelEinbinder
approved these changes
Oct 24, 2017
|
The entry in TOC needs updating: to |
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
…eteer#1152) This patch adds "options" parameter to the `page.setContent` method. The parameter is the same as a navigation parameter and allows to specify maximum timeout to wait for resources to be loaded, as well as to describe events that should be emitted before the setContent operation would be considered successful. Fixes puppeteer#728.
aslushnikov
added a commit
to aslushnikov/puppeteer
that referenced
this pull request
Nov 7, 2017
…ad (puppeteer#1152)" This reverts commit 80ee469. Lifecycle events are not ready yet to support the setContent scenario. The prerequisite for this to work is https://chromium-review.googlesource.com/c/chromium/src/+/747805 which might not land soon due to technical concerns.
aslushnikov
added a commit
that referenced
this pull request
Nov 7, 2017
…ad (#1152)" (#1312) This reverts commit 80ee469. Lifecycle events are not ready yet to support the setContent scenario. The prerequisite for this is https://chromium-review.googlesource.com/c/chromium/src/+/747805 that might not land soon due to technical concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds "options" parameter to the
page.setContentmethod. Theparameter is the same as a navigation parameter and allows to specify
maximum timeout to wait for resources to be loaded, as well as to
describe events that should be emitted before the setContent operation
would be considered successful.
Fixes #728.