docs: clean up mcp-server.md (archived link, Claude auth, Codex commands) [murmur:logfire-sdk/mcp-server-doc-cleanup] - #2205
Conversation
- Remove archived logfire-mcp repo link (no longer useful) - Cross-link the in-product MCP page (US + EU) near the top of the remote-server section so readers find the region-aware UI instructions - Claude Code: show `claude mcp login logfire` together with `claude mcp add` as one copyable block, replacing the manual /mcp slash-command steps - Codex: lead with "configures the US endpoint by default" so EU readers do not stop before the region caveat; remove redundant `codex mcp remove logfire` and `codex mcp login logfire` commands (`codex mcp add` overwrites and auto-triggers OAuth) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated the MCP setup guide to remove the archived repository link. Claude Code instructions now use explicit 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/how-to-guides/mcp-server.md`:
- Around line 75-76: Update the Claude MCP add command so the --transport http
option appears before the logfire server name, matching Claude Code’s documented
argument order; leave the login command unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 77a22ce6-dd3c-4a1e-98ee-839a72726866
📒 Files selected for processing (1)
docs/how-to-guides/mcp-server.md
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
pydantic/logfire(manual)pydantic/pydantic-ai(manual)pydantic/platform(auto-detected)pydantic/pydantic(auto-detected)
--transport http must come before the server name per Claude Code's documented CLI syntax: claude mcp add --transport http <name> <url> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks @coderabbitai -- all pre-merge checks passing. The inline argument-order fix (Message #2) has been applied in a follow-up commit.
Posted by Murmur |
|
|
||
| !!! note | ||
| The Logfire UI has per-client setup instructions at | ||
| [logfire-us.pydantic.dev/-/mcp](https://logfire-us.pydantic.dev/-/mcp) (US) or |
There was a problem hiding this comment.
I don't think this change should merge as long as those pages are missing codex
There was a problem hiding this comment.
split this note into another pr
Closes #2199
Summary
OLD_README.mdlink is kept.logfire-us.pydantic.dev/-/mcpandlogfire-eu.pydantic.dev/-/mcp, which know the correct region URL for each account./mcpslash-command steps withclaude mcp login logfireshown together withclaude mcp addin a single shell block.codex mcp remove logfire(does nothing when installed via the plugin, redundant anyway becausecodex mcp addoverwrites) andcodex mcp login logfire(codex mcp addauto-triggers OAuth; the extraloginopened a second identical browser tab). The EU switch block is now just thecodex mcp addcommand plus the new-conversation note.Test plan
claude mcp add logfire --transport http <url>followed byclaude mcp login logfirecompletes authentication without additional stepscodex mcp add logfire --url <eu-url>alone handles EU switch correctlyCreated via Murmur