Log more info about internal errors - #346
Merged
Merged
Conversation
Deploying logfire-docs with
|
| Latest commit: |
9ed4a77
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e701f26.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-internal-exception-tb.logfire-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 121 123 +2
Lines 8958 9040 +82
Branches 1171 1178 +7
=========================================
+ Hits 8958 9040 +82 ☔ View full report in Codecov by Sentry. |
alexmojaki
marked this pull request as ready for review
July 29, 2024 20:35
Kludex
reviewed
Jul 30, 2024
Kludex
approved these changes
Aug 5, 2024
| @@ -1,5 +1,6 @@ | |||
| from _typeshed import Incomplete | |||
| from collections.abc import Generator | |||
| from logfire._internal.stack_info import is_user_code as is_user_code | |||
Contributor
Author
There was a problem hiding this comment.
That's just what stubgen does, you can see it in lots of other places in the pyi files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #325