Mark optional params as Optional - #5128

Yes, those annoy me because my editor is too angry

You should remove implicit_optional = true from mypy configuration.

You should remove implicit_optional = true from mypy configuration.

Pretty sure that won't work as my editor is using pyright

You should remove implicit_optional = true from mypy configuration.

Pretty sure that won't work as my editor is using pyright

And I do like to do things correctly

It should be removed because you are removing implicit optional.
This is present because there were implicit optional.

It should be removed because you are removing implicit optional. This is present because there were implicit optional.

I just had a look for this option, and according to this article mypy disallows implicit optional since version 0.99.
The implicit optional type has been removed from PEP 484 in python/peps#689

Thanks @JensHeinrich