Skip to content

Conversation

@JanMV
Copy link
Contributor

@JanMV JanMV commented Oct 25, 2018

Force on wheels is Torque/radius, x- and y-position are first two entries of the state vector.

Example

  • There are no merge conflicts.
  • A figure (preferrably SVG) has been added for the example.
  • The required versions of all dependencie have been noted. (For
    notebooks, the version information
    extension
    is helpful
    for this.)
  • A run.py file that executes the example is included.
  • All reviewer comments have been addressed.

Force on wheels is Torque/radius, x- and y-position are first two entries of the state vector.
"xs = odeint(right_hand_side, x0, ts, args=(ts, us, values))\n",
"\n",
"plt.plot(xs[:,5], xs[:,6])\n",
"plt.plot(xs[:,0], xs[:,1])\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So was this plotting the velocities?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was, so not corresponding to the plot

@moorepants
Copy link
Member

This looks good, the tests are failing do to a SymPy issue. Merging.

Thanks for the contribution.

@moorepants moorepants merged commit 1602fae into pydy:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants