Resolve symlinks in the zip extraction containment check - #14327
Open
dkautomation23 wants to merge 3 commits into
Open
dkautomation23 wants to merge 3 commits into
dkautomation23 wants to merge 3 commits into
Conversation
The tar fallback path checks containment twice: once on the textual path and once with symlinks resolved. The zip path only did the textual check. Apply the same resolved check in unzip_file so both archive formats enforce the same invariant, and add a test for a member written through a symlink that already exists in the destination.
2ykwang
reviewed
Sep 23, 2026
2ykwang
left a comment
Member
There was a problem hiding this comment.
Could you share an example of how this can happen? unzip_file() doesn't seem to create symlinks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The tar fallback path checks containment twice: once on the textual path and once with symlinks resolved. The zip path only did the textual check. Apply the same resolved check in
unzip_fileso both archive formats enforce the same invariant, and add a test for a member written through a symlink that already exists in the destination.Unit suite on Linux / Python 3.13: 1,929 passed, 0 failed.
PR Checklist:
Assisted-by: Claude