Skip to content

Update base_wrapper.py#1109

Open
neha200 wants to merge 1 commit into
pywinauto:atspifrom
neha200:atspi
Open

Update base_wrapper.py#1109
neha200 wants to merge 1 commit into
pywinauto:atspifrom
neha200:atspi

Conversation

@neha200

@neha200 neha200 commented Aug 30, 2021

Copy link
Copy Markdown

Added static modifiers have been added in order to correct the unwanted pixels (Transparent and Colored Borders) being captured.

@codecov

codecov Bot commented Aug 30, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.28%. Comparing base (c0c84dc) to head (d29d20c).
⚠️ Report is 75 commits behind head on atspi.

Additional details and impacted files
@@            Coverage Diff             @@
##            atspi    #1109      +/-   ##
==========================================
- Coverage   89.28%   89.28%   -0.01%     
==========================================
  Files          58       58              
  Lines       22190    22190              
==========================================
- Hits        19813    19812       -1     
- Misses       2377     2378       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vasily-v-ryabov

Copy link
Copy Markdown
Contributor

It looks like workaround for #676. I'm not willing to merge such hard-coded magic numbers. It may depend on screen resolution and some other factors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants