add window_specification module and move WindowSpecification definition to that#1326
Draft
junkmd wants to merge 6 commits into
Draft
add window_specification module and move WindowSpecification definition to that#1326junkmd wants to merge 6 commits into
window_specification module and move WindowSpecification definition to that#1326junkmd wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
==========================================
+ Coverage 87.89% 94.16% +6.27%
==========================================
Files 60 61 +1
Lines 23063 23069 +6
==========================================
+ Hits 20271 21724 +1453
+ Misses 2792 1345 -1447 🚀 New features to boost your workflow:
|
| Current wrapper object is used as a parent while searching in the subtree. | ||
| """ | ||
| from .base_application import WindowSpecification | ||
| from .window_specification import WindowSpecification |
Check notice
Code scanning / CodeQL
Cyclic import
|
|
||
| from . import controls | ||
| from . import findbestmatch | ||
| from . import findwindows |
Check notice
Code scanning / CodeQL
Cyclic import
| from . import findbestmatch | ||
| from . import findwindows | ||
|
|
||
| from . import backend as backends |
Check notice
Code scanning / CodeQL
Cyclic import
junkmd
marked this pull request as draft
March 26, 2025 14:34
junkmd
force-pushed
the
separate_window_spec_module
branch
from
April 3, 2025 11:43
4a52153 to
6036a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
WindowSpecificationis referred from bothApplicationandDesktop, but it was defined in thebase_applicationmodule.Thus, the
Desktopneeds to import theWindowSpecificationfrombase_applicationmodule. It makes an undesirable dependency.Additionally,
WindowSpecificationis a concrete class, and defining it in a module namedbase_...feels somewhat out of place.I moved the definition of
WindowSpecificationto a module namedwindow_specification, similar to howBackEndin thebackendmodule.