Fix interpose([]) raising StopIteration - #635
Merged
eriknw merged 1 commit intoSep 18, 2026
Merged
Conversation
Calling next() on the zip/concat pipeline assumes at least one element. Return an empty iterator for empty sequences instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 1226 1229 +3
=========================================
+ Hits 1226 1229 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interpose(el, [])callednext()on an empty concat/zip pipeline and raisedStopIteration.Test plan
pytest toolz/tests/test_itertoolz.py -k interposelist(interpose('a', [])) == []andlist(interpose('a', [1,2,3])) == [1,'a',2,'a',3]