mboxMessage.get_payload throws TypeError on malformed content type #80361

Activity

1. enrico commented on Mar 4, 2019

   

   enricomannequin

   on Mar 4, 2019

   MannequinAuthor

   More actions

   This simple code:

   import mailbox
   
   mbox = mailbox.mbox("broken.mbox")
   for msg in mbox:
       msg.get_payload()
   

   Fails rather unexpectedly:

   $ python3 broken.py 
   Traceback (most recent call last):
     File "broken.py", line 5, in <module>
       msg.get_payload()
     File "/usr/lib/python3.7/email/message.py", line 267, in get_payload
       payload = bpayload.decode(self.get_param('charset', 'ascii'), 'replace')
   TypeError: decode() argument 1 must be str, not tuple
   

   (I'm attaching a zip with code and mailbox)

   I would have expected either that the part past text/plain is ignored if it doesn't make sense, or that content-type is completely ignored.

   I have to process a large mailbox archive, and this is currently how I had to work around this issue, and it's causing me to have to skip email content which would otherwise be reasonably accessible:

   https://salsa.debian.org/nm-team/echelon/commit/617ce935a31f6256257ffb24e11a5666306406c3
2. SilentGhost

   added

   topic-email

   3.7 (EOL)end of lifeend of life

   3.8 (EOL)end of lifeend of life

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Mar 4, 2019
3. tirkarthi commented on Apr 14, 2019

   

   tirkarthi

   on Apr 14, 2019

   Last edited by serhiy-storchaka

   Member

   More actions

   A simplified reproducer as below. The tuple is returned from here

   cpython/Lib/email/message.py

   Line 93 in 830b43d

   def _unquotevalue(value):

   and perhaps is an untested code path? The charset gets a tuple value of ('utf-8��', '', '"utf-8Â\xa0"') .

   import mailbox
   import tempfile
   
   broken_message = """
   From [list@murphy.debian.org](mailto:list@murphy.debian.org) Wed Sep 24 01:22:15 2003
   Date: Wed, 24 Sep 2003 07:05:50 +0200
   From: Test test <[test@example.or](mailto:test@example.or)>
   To: [debian-devel-french@lists.debian.org](mailto:debian-devel-french@lists.debian.org)
   Subject: Re: Test
   Mime-Version: 1.0
   Content-Type: text/plain; charset*=utf-8†''utf-8%C2%A0
   
   trés intéressé
   """
   
   with tempfile.NamedTemporaryFile() as f:
       f.write(broken_message.encode())
       f.seek(0)
       msg = mailbox.mbox(f.name)
       for m in msg:
           print(m.get_payload())

   $ ../cpython/python.exe bpo36180.py
   Traceback (most recent call last):
     File "bpo36180.py", line 21, in <module>
       print(m.get_payload())
     File "/Users/karthikeyansingaravelan/stuff/python/cpython/Lib/email/message.py", line 267, in get_payload
       payload = bpayload.decode(self.get_param('charset', 'ascii'), 'replace')
   TypeError: decode() argument 1 must be str, not tuple
   sys:1: ResourceWarning: unclosed file <_io.BufferedRandom name='/var/folders/2b/mhgtnnpx4z943t4cc9yvw4qw0000gn/T/tmp4ddavb6g'>
4. ezio-melotti

   transferred this issue fromon Apr 10, 2022
5. iritkatriel

   added

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Nov 23, 2023
6. serhiy-storchaka

   added 2 commits that reference this issue on Apr 17, 2024

   pythongh-80361: Fix TypeError in email.Message.get_payload()

   ...

   4a2882d

   gh-80361: Fix TypeError in email.Message.get_payload() (GH-117994)

   ...

   deaecb8
7. miss-islington

   added a commit that references this issue on Apr 17, 2024

   pythongh-80361: Fix TypeError in email.Message.get_payload() (pythonG…

   ...

   6bae37e
8. serhiy-storchaka

   closed this as completedon Apr 17, 2024
9. serhiy-storchaka

   added a commit that references this issue on Apr 17, 2024

   [3.12] gh-80361: Fix TypeError in email.Message.get_payload() (GH-117994

   ...

   fda8cd1