Skip to content

Wrong base class for transport returned by loop.create_datagram_endpoint() #90352

Closed

Description

@asvetlov
BPO 46194
Nosy @asvetlov, @1st1, @carlosdamazio, @carlosdamazio
PRs
  • bpo-46194: Make selector inherit asyncio.DatagramTransport #30291
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-12-29.14:56:23.713>
    labels = ['3.11', '3.8', '3.9', '3.10', 'expert-asyncio']
    title = 'Wrong base class for transport returned by loop.create_datagram_endpoint()'
    updated_at = <Date 2021-12-29.20:44:28.023>
    user = 'https://github.com/asvetlov'

    bugs.python.org fields:

    activity = <Date 2021-12-29.20:44:28.023>
    actor = 'carlosdamazio'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['asyncio']
    creation = <Date 2021-12-29.14:56:23.713>
    creator = 'asvetlov'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46194
    keywords = ['patch']
    message_count = 2.0
    messages = ['409309', '409326']
    nosy_count = 4.0
    nosy_names = ['asvetlov', 'yselivanov', 'dmzz', 'carlosdamazio']
    pr_nums = ['30291']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue46194'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10', 'Python 3.11']

    Activity

    1. asvetlov commented on Dec 29, 2021

      @asvetlov
      ContributorAuthor

      Selector-based event loops returns _SelectorDatagramTransport which inherits asyncio.Transport instead of asyncio.DatagramTransport.

      isinstance(transp, asyncio.DatagramTransport) fails.
      It doesn't affect the actual execution since transp.sendto() and transp.error_received() are correctly implemented.

      The bug doesn't affect Windows proactor-based implementation.

      The fix is relatively easy, a champion is welcome!

    2. carlosdamazio commented on Dec 29, 2021

      carlosdamaziomannequin
      Mannequin

      I think I have a fix for this, I opened a PR. Let me know if you have any questions.

    3. transferred this issue fromon Apr 10, 2022
    4. CAM-Gerlach commented on Oct 15, 2022

      @CAM-Gerlach
      Member

      For reference, that PR is #30291

    5. added
      type-bugAn unexpected behavior, bug, or error
      and removed on Oct 15, 2022
    6. Repository owner moved this from Todo to Done in asyncioon Oct 29, 2022
    7. added a commit that references this issue on Oct 29, 2022
    8. added a commit that references this issue on Oct 29, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Labels

    3.10 (EOL)end of life3.11only security fixes3.12only security fixestopic-asynciotype-bugAn unexpected behavior, bug, or error

    Projects

    • Status
      Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions