Repository navigation
test_lltrace fails on non-UTF-8 locale #91924
Description
$ LC_ALL=en_US.iso88591 ./python -m test -vuall test_lltrace
...
======================================================================
FAIL: test_lltrace (test.test_lltrace.TestLLTrace.test_lltrace)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/serhiy/py/cpython/Lib/test/test_lltrace.py", line 56, in test_lltrace
self.assertIn("GET_ITER", stdout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'GET_ITER' not found in "\nResuming frame for 'trace_me' in module '__main__'\n\nResuming frame for '<module>'\n stack=[None]\n62: POP_TOP\n stack=[]\n64: DELETE_NAME 3\n stack=[]\n66: PUSH_NULL\n stack=[<nil>]\n68: LOAD_NAME 2\n stack=[<nil>, <function dont_trace_2 at 0x7feae8a28890>]\n70: PRECALL 0\n stack=[<nil>, <function dont_trace_2 at 0x7feae8a28890>]\n74: CALL 0\n"
======================================================================
FAIL: test_lltrace_different_module (test.test_lltrace.TestLLTrace.test_lltrace_different_module)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/serhiy/py/cpython/Lib/test/test_lltrace.py", line 74, in test_lltrace_different_module
self.assertIn('LOAD_CONST', stdout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'LOAD_CONST' not found in "\nResuming frame for 'example' in module 'test.test_lltrace'\nthis is an example\n"
----------------------------------------------------------------------
Activity
sweeneyde commentedon Apr 26, 2022
How strange: I don't know how the encoding is preventing
printf()from working.serhiy-storchaka commentedon Apr 26, 2022
It may fail to decode a non-UTF-8 file path with UTF-8 and then silence all errors. It may be similar to #91922.
vstinner commentedon May 25, 2022
It's a subtle bug related to unicode_check_encoding_errors().
lltrace_resume_frame() => PyObject_Print() => PyUnicode_AsEncodedString() => unicode_check_encoding_errors() => _PyCodec_Lookup() => (...) => _PyEval_EvalFrame()
The _PyEval_EvalFrame() call executes encodings.search_function() which sets lltrace to 0.
I propose #93199 to fix it.
sweeneyde commentedon May 25, 2022
Thanks for the detective work!
Could we instead make
lltracea local variable forPyEval_EvalFrameDefault? I think that would be a beneficial change anyway: you then only trace functions in modules marked with__lltrace__, and it stays on after a call to a different module finishes.vstinner commentedon May 25, 2022
Let's discuss that in the PR instead.
pythongh-91924: Fix __lltrace__ for non-UTF-8 stdout encoding (python…
gh-91924: Fix __lltrace__ for non-UTF-8 stdout encoding (#93199)
gh-91924: Fix __lltrace__ for non-UTF-8 stdout encoding (GH-93199)
[3.10] gh-91924: Fix __ltrace__ for non-UTF-8 stdout encoding (#93214)
vstinner commentedon May 25, 2022
Fixed by:
gh-91924: Optimize unicode_check_encoding_errors() (#93200)