Activity

1. relent95

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Jul 28, 2022
2. hugovk

   added

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on Jul 28, 2022
3. hugovk commented on Jul 28, 2022

   

   hugovk

   on Jul 28, 2022

   Last edited by hugovk

   Member

   More actions

   Testing with Python 3.11, bgpic already accepts a PGM, PPM and PNG (but docs would need to be updated):

   import turtle
   
   tr = turtle.Turtle()
   wn = turtle.Screen()
   
   # filename = "./Lib/test/imghdrdata/python.gif"
   # filename = "./Lib/test/imghdrdata/python.pgm"
   # filename = "./Lib/test/imghdrdata/python.ppm"
   filename = "./Lib/test/imghdrdata/python.png"
   
   wn.bgpic(filename)
   wn.mainloop()

   ---

   Testing register_shape:

   from turtle import Screen, Turtle
   
   screen = Screen()
   screen.screensize(800, 800)
   
   # filename = "./Lib/test/imghdrdata/python.gif"
   # filename = "./Lib/test/imghdrdata/python.pgm"
   # filename = "./Lib/test/imghdrdata/python.ppm"
   filename = "./Lib/test/imghdrdata/python.png"
   
   screen.register_shape(filename)
   turtle = Turtle(filename)
   turtle.penup()
   turtle.goto(-280, -280)
   
   screen.mainloop()

   Works with a change something like this (plus docs would need updating):

   diff --git a/Lib/turtle.py b/Lib/turtle.py
   index a8876e76bc..3a9082c92a 100644
   --- a/Lib/turtle.py
   +++ b/Lib/turtle.py
   @@ -1131,7 +1131,12 @@ def register_shape(self, name, shape=None):
            """
            if shape is None:
                # image
   -            if name.lower().endswith(".gif"):
   +            if (
   +                    name.lower().endswith(".gif")
   +                    or name.lower().endswith(".png")
   +                    or name.lower().endswith(".pgm")
   +                    or name.lower().endswith(".ppm")
   +            ):
                    shape = Shape("image", self._image(name))
                else:
                    raise TurtleGraphicsError("Bad arguments for register_shape.\n"

   Alternatively, the extension check could be removed, and just let tkinter handle it, as is the case with bgpic:

   diff --git a/Lib/turtle.py b/Lib/turtle.py
   index a8876e76bc..cc33d37c34 100644
   --- a/Lib/turtle.py
   +++ b/Lib/turtle.py
   @@ -1131,11 +1131,7 @@ def register_shape(self, name, shape=None):
            """
            if shape is None:
                # image
   -            if name.lower().endswith(".gif"):
   -                shape = Shape("image", self._image(name))
   -            else:
   -                raise TurtleGraphicsError("Bad arguments for register_shape.\n"
   -                                          + "Use  help(register_shape)" )
   +            shape = Shape("image", self._image(name))
            elif isinstance(shape, tuple):
                shape = Shape("polygon", shape)
            ## else shape assumed to be Shape-instance

   _tkinter.TclError: couldn't recognize data in image file "1.py"
   
4. relent95

   added a commit that references this issue on Jul 28, 2022

   pythongh-95371: Add support for other image formats(e.g. PNG) to the …

   ...

   1e30349
5. relent95 commented on Jul 28, 2022

   

   relent95

   on Jul 28, 2022

   Last edited by relent95

   ContributorAuthor

   More actions

   Thanks hugovk, you are fast. I was working on a PR when you posted. My approach for register_shape coincides with your second one.
   You may ignore my PR if you are working on your own PR.

   👍React with 👍1Reacted by Hugo van Kemenade
6. relent95 commented on Feb 3, 2023

   

   relent95

   on Feb 3, 2023

   ContributorAuthor

   More actions

   Can anyone review the above PR? Because its base version is quite old, I can prepare a new PR if it's required.
7. serhiy-storchaka

   added this to Turtle issues 🐢on Sep 3, 2023
8. hugovk

   added a commit that references this issue on Jan 2, 2025

   gh-95371: Add support for other image formats(e.g. PNG) to the turtle… (

   ...

   e1baa77
9. hugovk

   closed this as completedon Jan 2, 2025
10. github-project-automation

    moved this to Done in Turtle issues 🐢on Jan 2, 2025
11. srinivasreddy

    added a commit that references this issue on Jan 8, 2025

    pythongh-95371: Add support for other image formats(e.g. PNG) to the …

    ...

    b3a6c43