Skip to content

dis output is missing information for KW_NAMES #99944

Closed

Description

@chilaxan

Bug report

dis output is missing the constant value for KW_NAMES

This is due to a hardcoded check that the op is LOAD_CONST before grabbing the value.
This check comes after a check that the opcode is in dis.hasconst, so reasonably it can be removed to allow KW_NAMES and future opcodes that feature constants to work moving forward.

I have drafted a simple pull request #99943 to fix this bug

Linked PRs

Activity

  1. Sarenard commented on Mar 14, 2023

    @Sarenard

    It seems that i have the same problem, is this pr still active?

  2. arhadthedev commented on Apr 1, 2023

    @arhadthedev
    Member

    @Lorisredstone The PR needs tests and there is nobody with free time to dig into the matter and add them.

  3. added a commit that references this issue on Apr 26, 2023
  4. iritkatriel commented on Apr 26, 2023

    @iritkatriel
    Member

    Thank you @chilaxan and @jkchandalia.

  5. added a commit that references this issue on Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions