Skip to content

Speed up pathlib.PurePath.[is_]relative_to() #111429

Closed
Closed
Speed up pathlib.PurePath.[is_]relative_to()#111429
Labels
performancePerformance or resource usagetopic-pathlib

Description

@barneygale
barneygale
opened on Oct 28, 2023

Both methods call self.with_segments() unconditionally. This can be skipped if the other argument is already an instance of PurePath, and no further (deprecated) positional arguments are given.

Also, relative_to() can inline the core of the is_relative_to() check to avoid the type/deprecated args checks.

Linked PRs

Activity

  1. barneygale
    added
    performancePerformance or resource usage
    topic-pathlib
    on Oct 28, 2023
  2. barneygale
    added a commit that references this issue on Oct 28, 2023

    pythonGH-111429: Speed up `pathlib.PurePath.[is_]relative_to()`

    6e93540
  3. barneygale
    added a commit that references this issue on Nov 12, 2023

    GH-111429: Speed up `pathlib.PurePath.[is_]relative_to()` (#111431)

    d7cef7b

  4. barneygale commented on Nov 12, 2023

    @barneygale
    barneygale
    on Nov 12, 2023
    ContributorAuthor

    Resolved in 3.13 / 6e93540 / #111431

  5. barneygale
    closed this as completedon Nov 12, 2023
  6. aisk
    added a commit that references this issue on Feb 11, 2024

    pythonGH-111429: Speed up `pathlib.PurePath.[is_]relative_to()` (pyth…

    479427c
  7. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythonGH-111429: Speed up `pathlib.PurePath.[is_]relative_to()` (pyth…

    1e89dcf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    performancePerformance or resource usagetopic-pathlib

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions