Skip to content

_selectmodule.c does not handle errors when creating a module #111233

Closed
Closed
_selectmodule.c does not handle errors when creating a module#111233
Assignees
sobolevn
Labels
extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Oct 23, 2023

Bug report

It is documented that PyModule_AddIntMacro can raise an error (and it can in fact):

.. c:macro:: PyModule_AddIntMacro(module, macro)

   Return ``-1`` on error, ``0`` on success.

But, some calls are not checked for errors:

cpython/Modules/selectmodule.c

Lines 2471 to 2476 in 96cbd1e

PyModule_AddIntMacro(m, POLLIN);
PyModule_AddIntMacro(m, POLLPRI);
PyModule_AddIntMacro(m, POLLOUT);
PyModule_AddIntMacro(m, POLLERR);
PyModule_AddIntMacro(m, POLLHUP);
PyModule_AddIntMacro(m, POLLNVAL);

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    extension-modulesC modules in the Modules dir
    on Oct 23, 2023
  2. sobolevn
    self-assigned this
    on Oct 23, 2023
  3. sobolevn
    added a commit that references this issue on Oct 23, 2023

    pythongh-111233: Fix `selectmodule.c` not checking for errors when in…

    0e7a5a1
  4. erlend-aasland
    added a commit that references this issue on Oct 25, 2023

    gh-111233: Fix error checking in select extension module init (#111234)

    2838c55

  5. hugovk commented on Nov 9, 2023

    @hugovk
    hugovk
    on Nov 9, 2023
    Member

    Thanks!

  6. hugovk
    closed this as completedon Nov 9, 2023
  7. aisk
    added a commit that references this issue on Feb 11, 2024

    pythongh-111233: Fix error checking in select extension module init (p…

    765d4ce
  8. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-111233: Fix error checking in select extension module init (p…

    d3507c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions