closing async_generator_athrow on an async generator that suppresses GeneratorExit does not raise RuntimeError

Bug report

Bug description:

when running agen.aclose().close() it should throw GeneratorExit into the coroutine and raise RuntimeError from .close():

import types

@types.coroutine
def _async_yield(v):
    return (yield v)

async def agenfn():
    try:
        yield 1
    finally:
        try:
            await _async_yield(2)
        except GeneratorExit:
            print("generator exit")
            await _async_yield(3)


agen = agenfn()
try:
    anext(agen).send(None)
except StopIteration as e:
    print(e.value)

try:
    agen.aclose().close()
except RuntimeError:
    print("good")
else:
    print("bad")

prints:

1
bad
Exception ignored in: <async_generator object agenfn at 0x7e0c43b09620>
RuntimeError: async generator ignored GeneratorExit

CPython versions tested on:

3.11, 3.12, 3.13, CPython main branch

Operating systems tested on:

Linux

Linked PRs

it looks like async_gen_athrow_close just marks the async_generator_athrow as closed and returns None, instead it should call gen_throw with a GeneratorExit object and transform any return values into RuntimeError exceptions.

cpython/Objects/genobject.c

Lines 2244 to 2249 in 6bc0b33

    
           static PyObject * 
        
           async_gen_athrow_close(PyAsyncGenAThrow *o, PyObject *args) 
        
           { 
        
               o->agt_state = AWAITABLE_STATE_CLOSED; 
        
               Py_RETURN_NONE; 
        
           }

this also applies to async_generator_asend.close()

another example showing aclose().close() doesn't finalize the generator:

import types
finalized = False

@types.coroutine
def _async_yield(v):
    return (yield v)

async def agenfn():
    global finalized
    try:
        yield 1
    finally:
        try:
            await _async_yield(2)
        except GeneratorExit:
            finalized = True
            raise


agen = agenfn()
try:
    anext(agen).send(None)
except StopIteration as e:
    print(e.value)

aclose = agen.aclose()
print(f"{aclose.send(None)=}")
aclose.close()
print(f"{finalized=}")

pythonGH-117714: replace athrow().close() and asend().close() stubs w…

GH-117714: implement athrow().close() and asend().close() using throw (…

pythonGH-117714: implement athrow().close() and asend().close() using…

fix(django): support async views and middleware under ASGI on Python …

Fix AsyncGenerator following CPython (GH-7777)

Navigation Menu

Repository navigation

closing async_generator_athrow on an async generator that suppresses GeneratorExit does not raise RuntimeError #117714

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	static PyObject *
	async_gen_athrow_close(PyAsyncGenAThrow o, PyObject args)
	{
	o->agt_state = AWAITABLE_STATE_CLOSED;
	Py_RETURN_NONE;
	}

closing async_generator_athrow on an async generator that suppresses GeneratorExit does not raise RuntimeError #117714

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

graingert commented on Apr 10, 2024

graingert commented on Apr 10, 2024

graingert commented on Apr 11, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions