Skip to content

Tools/jit/_llvm.py doesn't support LLVM_VERSION_SUFFIX #120602

Closed
Closed
Tools/jit/_llvm.py doesn't support LLVM_VERSION_SUFFIX#120602
Labels
buildThe build process and cross-buildtopic-JITtype-bugAn unexpected behavior, bug, or error

Description

@xarblu
xarblu
opened on Jun 16, 2024

Bug report

Bug description:

I initially encountered this build issue on Gentoo.

Currently the regex in Tools/jit/_llvm.py only allows strings of the form version MAJOR.MINOR.PATCH

_LLVM_VERSION_PATTERN = re.compile(rf"version\s+{_LLVM_VERSION}\.\d+\.\d+\s+")

However if LLVM was built with e.g. -DLLVM_VERSION_SUFFIX=+libcxx (as is the case on Gentoo) clang --version would return clang version 18.1.7+libcxx which is a valid version but doesn't match.

My proposed fix would be to simply allow a non-whitespace string of arbitrary length after the version, i.e.:

_LLVM_VERSION_PATTERN = re.compile(rf"version\s+{_LLVM_VERSION}\.\d+\.\d+\S*\s+")

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs

Activity

  1. xarblu
    added
    type-bugAn unexpected behavior, bug, or error
    on Jun 16, 2024
  2. Eclips4
    added
    buildThe build process and cross-build
    topic-JIT
    on Jun 16, 2024

  3. Eclips4 commented on Jun 16, 2024

    @Eclips4
    Eclips4
    on Jun 16, 2024
    Member

    Hello!
    Would you like to send a PR? 🙂

  4. xarblu
    added a commit that references this issue on Jun 16, 2024

    pythongh-120602: Support LLVM_VERSION_SUFFIX

    69e43a9

  5. xarblu commented on Jun 16, 2024

    @xarblu
    xarblu
    on Jun 16, 2024
    ContributorAuthor

    Yes, I'm in the process of sending it. Just following the contribution guidelines and made the issue first :)

  6. xarblu
    added a commit that references this issue on Jun 19, 2024

    pythongh-120602: Support LLVM_VERSION_SUFFIX

    6c68903
  7. brandtbucher
    added a commit that references this issue on Jun 20, 2024

    GH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (GH-120604)

    285f42c
  8. miss-islington
    added a commit that references this issue on Jun 20, 2024

    pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…

    84cbf60
  9. brandtbucher
    closed this as completedon Jun 20, 2024
  10. brandtbucher
    added a commit that references this issue on Jun 20, 2024

    [3.13] GH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (GH-120768)

    6b714d5
  11. mrahtz
    added a commit that references this issue on Jun 30, 2024

    pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…

    24b8cbb
  12. noahbkim
    added a commit that references this issue on Jul 11, 2024

    pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…

    48e364c
  13. estyxx
    added a commit that references this issue on Jul 17, 2024

    pythonGH-120602: Support LLVM_VERSION_SUFFIX for JIT builds (pythonGH…

    05290cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildThe build process and cross-buildtopic-JITtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions