Skip to content

Remove duplicative Py_DECREF when handling _PyOptimizer_Optimize errors #123545

Closed

Description

@savannahostrowski

There are two places in the code where we call Py_DECREF twice when _PyOptimizer_Optimize returns -1. In both cases, we do so in the conditional block and then as part of the GOTO_UNWIND macro. This never really happens in practice, but it would be problematic if this error'd.

if (optimized < 0) {

if (optimized < 0) {

Linked PRs

Activity

  1. added
    type-bugAn unexpected behavior, bug, or error
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    3.13only security fixes
    3.14bugs and security fixes
    on Sep 3, 2024
  2. added a commit that references this issue on Sep 5, 2024
  3. added a commit that references this issue on Sep 6, 2024
  4. added a commit that references this issue on Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions