Repository navigation
codegen should ideally not need to know the optimization level #123958
Description
Optimization level is used for things that can be done in ast_opt. I'll try to move them there.
{{ message }}
Optimization level is used for things that can be done in ast_opt. I'll try to move them there.
Activity
gh-123958: apply docstring removal optimization in ast_opt instead of…
hugovk commentedon Sep 15, 2024
PR merged, closing issue.
iritkatriel commentedon Sep 15, 2024
There's another usage still to remove.
hugovk commentedon Sep 15, 2024
Thanks, sorry I was too quick with the close button :)
Eclips4 commentedon Sep 15, 2024
So, the only remaining occurrence of
OPTIMIZATION_LEVELis related to theassertstatement.@iritkatriel, are you currently working on this? If not, can I attempt to fix it?
iritkatriel commentedon Sep 15, 2024
I have a patch for it. Thanks.
pythongh-123958: move assert optimization from codegen to ast_opt
iritkatriel commentedon Sep 17, 2024
I got as far as I could with this, the assert optimization needs to stay in ast_opt (see discussion on PR).