AST optimizer skips PEP 696 type parameter defaults

@Eclips4

Bug report

Bug description:

>>> dis.dis("def f[T = 1 + 2](): pass")
... snip ...
      L1:     LOAD_CONST               0 (1)
              LOAD_CONST               1 (2)
              BINARY_OP                0 (+)

... snip ...

cc @Eclips4. This is easy to fix but it might be better to wait for #122667 so we can test the fix better.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

diff --git Python/ast_opt.c Python/ast_opt.c
index d7a26e64150..8907c6daec7 100644
--- Python/ast_opt.c
+++ Python/ast_opt.c
@@ -1087,6 +1087,7 @@ astfold_type_param(type_param_ty node_, PyArena *ctx_, _PyASTOptimizeState *stat
     switch (node_->kind) {
         case TypeVar_kind:
             CALL_OPT(astfold_expr, expr_ty, node_->v.TypeVar.bound);
+            CALL_OPT(astfold_expr, expr_ty, node_->v.TypeVar.default_value);
             break;
         case ParamSpec_kind:
             break;

This might help someone in the future, I tested it locally: echo 'def f[T = 1 + 2](): pass' | ./python.exe -m dis

LOAD_CONST               3 (<code object f at 0x1019cab60, file "<stdin>", line 1>)

The same change is also needed for the ParamSpec and TypeVarTuple cases though.

@wrongnull

If no one complains, I would like to work with @wrongnull on this

gh-123344: Add missing ast optimizations for PEP 696 (#123377)

pythongh-123344: Add missing ast optimizations for PEP 696 (pythonGH-…

[3.13] gh-123344: Add missing ast optimizations for PEP 696 (GH-123377)…

Navigation Menu

Repository navigation

AST optimizer skips PEP 696 type parameter defaults #123344

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

AST optimizer skips PEP 696 type parameter defaults #123344

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

sobolevn commented on Aug 26, 2024

JelleZijlstra commented on Aug 26, 2024

Eclips4 commented on Aug 26, 2024

picnixz commented on Aug 28, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions