Repository navigation
colors are missing on (Base)ExceptionGroup tracebacks in the pyrepl #125593
Description
Bug description:
import sys
class InvalidFruitException(Exception):
pass
def eat_fruit(fruit):
if fruit == "banana":
raise InvalidFruitException("no herbs please, only fruit")
if fruit == "rock":
raise InvalidFruitException("too tough")
def demo_continue_loop():
food = ["apple", "rock", "orange", "banana"]
exceptions = []
try:
for i, f in enumerate(food):
try:
eat_fruit(f)
except Exception as e:
e.add_note(f"failed on loop {i=} {f=}")
exceptions.append(e)
if exceptions:
raise ExceptionGroup("multiple errors eating food", exceptions)
finally:
del exceptions # no refcycles please!
def main():
demo_continue_loop()
return 0
if __name__ == "__main__":
sys.exit(main())here's the output:
https://asciinema.org/a/681263
I'd expect the eat_fruit() parts to be highlighted in red
CPython versions tested on:
3.13, 3.14
Operating systems tested on:
Linux, macOS
This was added in #112730 but it looks like ExceptionGroups were missed
Activity
[-]colors are missing on ExceptionGroup tracebacks[/-][+]colors are missing on ExceptionGroup tracebacks in the pyrepl[/+]Eclips4 commentedon Oct 16, 2024
@graingert are you working on this issue? If not, @wrongnull would like to take this one :)
graingert commentedon Oct 16, 2024
@Eclips4 no I've not looked into it yet
[-]colors are missing on ExceptionGroup tracebacks in the pyrepl[/-][+]colors are missing on (Base)ExceptionGroup tracebacks in the pyrepl[/+]graingert commentedon Oct 16, 2024
one minor request I have is that exception notes have a color distinct to exception messages
wrongnull commentedon Oct 16, 2024
I'm working on this and found a fix. The pull request will be sent tomorrow
gh-125593: Use colors to highlight error locations in tracebacks from…
pythongh-125593: Use colors to highlight error locations in traceback…
[3.13] gh-125593: Use colors to highlight error locations in tracebac…
pythongh-125593: Use colors to highlight error locations in traceback…