Skip to content

urllib.request.url2pathname() mishandles a UNC URI variant #127078

Closed
Closed
urllib.request.url2pathname() mishandles a UNC URI variant#127078
Labels
3.12only security fixes3.13only security fixes3.14bugs and security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@barneygale
barneygale
opened on Nov 20, 2024

Bug report

Bug description:

On Windows, urllib.request.url2pathname() mishandles an uncommon file URI variant encoding a UNC path. Specifically, a URI with five leading slashes should be converted to a UNC path with two leading slashes, but url2pathname() returns a path with three leading slashes. Such URIs are created by software that simply prepends file:/// to a Windows path. See RFC 8089 E.3.2, final example.

>>> from urllib.request import url2pathname
>>> url2pathname('/////server/share')
'\\\\\\server\\share'  # expected: '\\\\server\\share'

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs

Activity

  1. barneygale
    added
    type-bugAn unexpected behavior, bug, or error
    3.12only security fixes
    3.13only security fixes
    3.14bugs and security fixes
    stdlibStandard Library Python modules in the Lib/ directory
    on Nov 20, 2024

  2. barneygale commented on Nov 20, 2024

    @barneygale
    barneygale
    on Nov 20, 2024
    ContributorAuthor

    I think we should wait for #126367 to be fixed before tackling this bug

  3. barneygale commented on Nov 22, 2024

    @barneygale
    barneygale
    on Nov 22, 2024
    ContributorAuthor

    I think we should wait for #126367 to be fixed before tackling this bug

    On second thought, it's better to solve this issue first to avoid backport conflicts.

  4. barneygale
    added 2 commits that reference this issue on Nov 22, 2024

    pythonGH-127078: `url2pathname()`: handle extra slash before UNC driv…

    2e59259

    GH-127078: `url2pathname()`: handle extra slash before UNC drive in U…

    8c98ed8
  5. miss-islington
    added 2 commits that reference this issue on Nov 22, 2024

    pythonGH-127078: `url2pathname()`: handle extra slash before UNC driv…

    ea42cf1

    pythonGH-127078: `url2pathname()`: handle extra slash before UNC driv…

    722c8d5
  6. barneygale
    added 2 commits that reference this issue on Nov 22, 2024

    [3.13] GH-127078: `url2pathname()`: handle extra slash before UNC dri…

    7bbcd32

    [3.12] GH-127078: `url2pathname()`: handle extra slash before UNC dri…

    c470e82
  7. barneygale
    closed this as completedon Nov 22, 2024
  8. ebonnal
    added a commit that references this issue on Jan 12, 2025

    pythonGH-127078: `url2pathname()`: handle extra slash before UNC driv…

    feb53eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.12only security fixes3.13only security fixes3.14bugs and security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions