Skip to content

zstd should use Py_XSETREF #134885

Closed
Closed

Description

@JelleZijlstra

Bug report

Bug description:

There is a theoretical crash path in the new zstd module that can be avoided with Py_XSETREF. PR incoming.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

  1. added a commit that references this issue on May 29, 2025
  2. added a commit that references this issue on May 30, 2025
  3. added a commit that references this issue on May 30, 2025
  4. ZeroIntensity commented on May 30, 2025

    @ZeroIntensity
    Member

    cc @emmatyping (the fix is already merged, but I just thought you'd want to be aware of it)

  5. added a commit that references this issue on May 30, 2025
  6. encukou commented on May 30, 2025

    @encukou
    Member

    Thank you for the fix!

  7. emmatyping commented on May 30, 2025

    @emmatyping
    Member

    Yes thank you! TIL about Py_XSETREF!

  8. added a commit that references this issue on Jul 12, 2025
  9. added a commit that references this issue on Aug 4, 2025
  10. added a commit that references this issue on Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.14bugs and security fixes3.15bugs and security fixesextension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions