Skip to content

The return_value docstring is set incorrectly in unittest.mock.NonCallableMock #156970

Closed
Closed
The return_value docstring is set incorrectly in unittest.mock.NonCallableMock#156970
Labels
stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@IvyXu420
IvyXu420
opened on Sep 5, 2026

Bug report

Bug description:

cpython/Lib/unittest/mock.py

Lines 596 to 598 in e56f86f

__return_value_doc = "The value to be returned when the mock is called."
return_value = property(__get_return_value, __set_return_value,
__return_value_doc)

Should be:

 return_value = property(__get_return_value, __set_return_value, 
                         doc=__return_value_doc)

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

  1. IvyXu420
    added
    type-bugAn unexpected behavior, bug, or error
    on Sep 5, 2026

  2. suhanemathur commented on Sep 5, 2026

    @suhanemathur
    suhanemathur
    on Sep 5, 2026

    Hi! @ByteFlowing1337 , I would like to take this issue up.

  3. IvyXu420 commented on Sep 5, 2026

    @IvyXu420
    IvyXu420
    on Sep 5, 2026
    ContributorAuthor

    @suhanemathur Sorry, but I already made a PR: #156971

  4. picnixz
    added
    stdlibStandard Library Python modules in the Lib/ directory
    on Sep 5, 2026
  5. StanFromIreland
    added this to Unittest & doctest issueson Sep 5, 2026
  6. github-project-automation
    moved this to Todo in Unittest & doctest issueson Sep 5, 2026
  7. StanFromIreland
    added a commit that references this issue on Sep 5, 2026

    gh-156970: Set `Mock.return_value`'s docstring (#156971)

    e620377
  8. StanFromIreland
    closed this as completedon Sep 5, 2026
  9. github-project-automation
    moved this from Todo to Done in Unittest & doctest issueson Sep 5, 2026
  10. StanFromIreland
    added 2 commits that reference this issue on Sep 5, 2026

    [3.13] gh-156970: Set `Mock.return_value`'s docstring (GH-156971) (#1…

    0da9c27

    [3.14] gh-156970: Set `Mock.return_value`'s docstring (GH-156971) (#1…

    5532330
  11. hugovk
    added a commit that references this issue on Sep 5, 2026

    [3.15] gh-156970: Set `Mock.return_value`'s docstring (GH-156971) (#1…

    7ad4634
  12. clin1234
    added a commit that references this issue on Sep 12, 2026

    pythongh-156970: Set `Mock.return_value`'s docstring (python#156971)

    d0ff6a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions