Repository navigation
Conversation
…reaks When multiple breakpoints share the same line, iterating over blist while calling bp.deleteMe() (which mutates blist) causes alternate elements to be skipped, leaving orphan breakpoints. This is a one-character fix: add [:] to create a copy before iterating, matching the existing defensive pattern in clear_break() at line 722.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
This PR is stale because it has been open for 90 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When multiple breakpoints share the same line, iterating over
blistwhilecalling
bp.deleteMe()(which mutatesblist) causes alternate elementsto be skipped, leaving orphan breakpoints.
This is a one-character fix: add
[:]to create a copy before iterating,matching the existing defensive pattern in
clear_break()at line 722.The Bug
Example
For N breakpoints at the same (file, line),
floor(N/2)orphans remainin
Breakpoint.bplistandBreakpoint.bpbynumber.Testing
This follows the same pattern already used in
clear_break()at line 722,which was confirmed working by the maintainers.
See issue #149015 for more details.