gh-95411: IDLE - Enable using the module browser with .pyw files by erlend-aasland · Pull Request #95397 · python/cpython

erlend-aasland · 2022-07-28T17:45:07Z

Issue: IDLE: Browse non-.py python files #95411

This reverts commit a7757f7.

terryjreedy

For me on main, .pyw can be browsed, .pyi cannot. I am not surprised because .pyi files cannot be imported and it could be said that they are not modules. In any case, pyclbr use importlib in spec = importlib.util._find_spec_from_path(fullmodule, search_path) and calls
spec.submodule_search_locations and spec.loader.get_source. We might have to continue to exclude .pyi files.

bedevere-bot · 2022-07-29T04:04:44Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

- use util.py_extensions in test - remove now obsoleted UtilTest.test_extensions

erlend-aasland · 2022-07-29T08:09:10Z

I am not surprised because .pyi files cannot be imported and it could be said that they are not modules.
In any case, pyclbr use importlib in spec = importlib.util._find_spec_from_path(fullmodule, search_path) and calls
spec.submodule_search_locations and spec.loader.get_source. We might have to continue to exclude .pyi files.

The pyclbr module; TIL.

Anyway, I agree with this. ~~That makes this PR moot, though. We can close it together with the linked PR.~~

One possibility is to use two sets:

supported importable extensions
supported highlightable extensions (extending the former)

Another solution: add more data to the set and couple it with e.g. is_browseable_extension helper

py_extensions = (
    # (ext, browseable)
    (".py", True),
    (".pyw", True),
    (".pyi", False),
)
# possible enhancement: use namedtuple iso. ordinary tuple

Third, and simplest solution: add a new can_browse_extension (or is_browseable_extension) helper that explicitly excludes .pyi.

erlend-aasland · 2022-07-29T09:05:38Z

I believe I have made the requested changes; please review again.

bedevere-bot · 2022-07-29T09:05:42Z

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

terryjreedy

Pending a last look, I expect to merge after you move the browser stuff as requested above.

bedevere-bot · 2022-07-29T17:53:33Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

…H.rst

erlend-aasland · 2022-07-29T18:43:00Z

I have made the requested changes; please review again.

bedevere-bot · 2022-07-29T18:43:03Z

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

miss-islington · 2022-07-30T04:42:16Z

Thanks @erlend-aasland for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

bedevere-bot · 2022-07-30T04:42:30Z

GH-95457 is a backport of this pull request to the 3.11 branch.

pythonGH-95397) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 7e19e41) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

bedevere-bot · 2022-07-30T04:42:35Z

GH-95458 is a backport of this pull request to the 3.10 branch.

…95397) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 7e19e41) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

pythongh-89610: Don't hardcode supported extensions in IDLE browser

85af3c4

erlend-aasland requested a review from terryjreedy as a code owner July 28, 2022 17:45

erlend-aasland added needs backport to 3.10 needs backport to 3.11 only security fixes skip news labels Jul 28, 2022

erlend-aasland requested a review from AlexWaygood July 28, 2022 17:45

bedevere-bot added the awaiting core review label Jul 28, 2022

erlend-aasland mentioned this pull request Jul 28, 2022

Make IDLE recognize .pyi stub files as source for open, save, and edit #89610

Closed

List of extensions should be a set data type

a7757f7

erlend-aasland commented Jul 28, 2022

View reviewed changes

Comment thread Lib/idlelib/util.py Outdated

Revert "List of extensions should be a set data type"

0c6e068

This reverts commit a7757f7.

erlend-aasland requested a review from merwok July 28, 2022 18:40

erlend-aasland added 2 commits July 28, 2022 20:42

Imports are sorted; insert new import at correct spot

d15dc3e

Also test extension is None

bdd73c6

merwok removed their request for review July 28, 2022 18:50

terryjreedy changed the title ~~gh-89610: Don't hardcode supported extensions in IDLE browser~~ gh-95411: Don't hardcode supported extensions in IDLE browser Jul 29, 2022

terryjreedy requested changes Jul 29, 2022

View reviewed changes

Comment thread Lib/idlelib/idle_test/test_util.py Outdated

bedevere-bot added awaiting changes and removed awaiting core review labels Jul 29, 2022

Address review:

2041cca

- use util.py_extensions in test - remove now obsoleted UtilTest.test_extensions

erlend-aasland added pending The issue will be closed if no feedback is provided and removed pending The issue will be closed if no feedback is provided labels Jul 29, 2022

Address review: drop support for .pyi in browser

de3ba24

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 29, 2022

bedevere-bot requested a review from terryjreedy July 29, 2022 09:05

terryjreedy changed the title ~~gh-95411: Don't hardcode supported extensions in IDLE browser~~ gh-95411: IDLE - Enable using the module browser with .pyw files Jul 29, 2022

terryjreedy requested changes Jul 29, 2022

View reviewed changes

Comment thread Misc/NEWS.d/next/IDLE/2022-07-29-11-08-52.gh-issue-95411.dazlqH.rst Outdated

Comment thread Lib/idlelib/NEWS.txt Outdated

bedevere-bot removed the awaiting change review label Jul 29, 2022

bedevere-bot added the awaiting changes label Jul 29, 2022

terryjreedy and others added 5 commits July 29, 2022 13:53

Update Misc/NEWS.d/next/IDLE/2022-07-29-11-08-52.gh-issue-95411.dazlq…

525db98

…H.rst

Update Lib/idlelib/NEWS.txt

be2c8c7

Address review: move to browser

09b248d

Merge branch 'main' into idle/dont-hardcode-extensions

15779a4

Revert now unused changes in util.py

04eef64

bedevere-bot added awaiting change review and removed awaiting changes labels Jul 29, 2022

bedevere-bot requested a review from terryjreedy July 29, 2022 18:43

Fix test

fbc140f

terryjreedy merged commit 7e19e41 into python:main Jul 30, 2022

bedevere-bot removed the awaiting change review label Jul 30, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 30, 2022

bedevere-bot removed the needs backport to 3.10 label Jul 30, 2022

erlend-aasland deleted the idle/dont-hardcode-extensions branch July 30, 2022 05:45

erlend-aasland mentioned this pull request Jul 30, 2022

IDLE: Browse non-.py python files #95411

Closed

AlexWaygood removed their request for review August 4, 2022 12:30

Conversation

erlend-aasland commented Jul 28, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

terryjreedy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Jul 29, 2022

Uh oh!

erlend-aasland commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Jul 29, 2022

Uh oh!

bedevere-bot commented Jul 29, 2022

Uh oh!

terryjreedy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jul 29, 2022

Uh oh!

erlend-aasland commented Jul 29, 2022

Uh oh!

bedevere-bot commented Jul 29, 2022

Uh oh!

miss-islington commented Jul 30, 2022

Uh oh!

bedevere-bot commented Jul 30, 2022

Uh oh!

bedevere-bot commented Jul 30, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented Jul 28, 2022 •

edited by bedevere-bot

Loading

erlend-aasland commented Jul 29, 2022 •

edited

Loading

terryjreedy left a comment •

edited

Loading