Skip to content

Impression - #46

Merged
lawik merged 14 commits into
pappersverk:impressionfrom
jasonmj:impression
Jul 11, 2022
Merged

Impression#46
lawik merged 14 commits into
pappersverk:impressionfrom
jasonmj:impression

Conversation

@jasonmj

@jasonmj jasonmj commented Jul 3, 2022

Copy link
Copy Markdown
Collaborator

Adding my WIP commits to add scenic support for the inky impression. I was able to get the screen to load something through scenic:
image

In order to do this, I needed to fork and update the pappersverk/scenic_driver_inky repo with a few changes to accomodate the impression. My work toward supporting the impression has occurred on a fork of inky on the impression branch.

Unfortunately, I'm stuck at a point where the output appears at 1/4 the size it should be and 4X across the screen. I've pushed my test project to https://github.com/jasonmj/impression where the inky and scenic_driver_inky deps are set to my forks.

Aiming to catch up with @axelson about it soon. See comments in code and on GitHub for more details.

Comment thread lib/display/display.ex
Comment thread lib/display/display.ex Outdated
Comment thread lib/hal/impression/rpihal.ex
Comment thread lib/hal/impression/rpihal.ex Outdated
Comment thread lib/hal/impression/rpihal.ex Outdated
Comment thread lib/hal/impression/rpihal.ex Outdated
Comment thread lib/display/display.ex
Comment thread lib/hal/impression/rpihal.ex Outdated
Comment thread lib/hal/impression/rpihal.ex Outdated
@jasonmj jasonmj self-assigned this Jul 3, 2022
@jasonmj jasonmj added the enhancement New feature or request label Jul 3, 2022
@jasonmj
jasonmj marked this pull request as ready for review July 3, 2022 19:48
@jasonmj

jasonmj commented Jul 6, 2022

Copy link
Copy Markdown
Collaborator Author

Managed to get the device displaying at the correct size with help from @axelson! We found there was one small change needed to accomplish this:
image

Of course, this change will need to get reworked a little bit so that it's only applied for the Impression, but hey, progress!

Next, we'll need to investigate how to get other colors printing to the screen. Right now, it just does black and white.

@jasonmj

jasonmj commented Jul 8, 2022

Copy link
Copy Markdown
Collaborator Author

Success! We now have a full support for the Inky Impression when using scenic:
image

I've cleaned up most of the code in this commit, though the merge to master may still need some tidying.

I've also submitted a pr to the scenic_driver_inky repo that is required to get this all working: pappersverk/scenic_driver_inky#6

In my test repository, I've included an example of how to configure the driver: https://github.com/jasonmj/impression/blob/6692ea50ba044e10c4099cc3aa423dbe7e93e95c/config/config.exs#L34

@jasonmj

jasonmj commented Jul 11, 2022

Copy link
Copy Markdown
Collaborator Author

@lawik can I merge this PR to the impression branch and then work to clean up the diff for a PR to master?

@lawik
lawik merged commit d5bca11 into pappersverk:impression Jul 11, 2022
@lawik

lawik commented Jul 11, 2022

Copy link
Copy Markdown
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants